Skip to content

Conversation

@tiftran
Copy link
Contributor

@tiftran tiftran commented Nov 24, 2025

References

Description

Just a temp measure to ensure people don't have a bad dev experience, while we figure out how best to address the slow/flaky sports tests.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

┆Issue is synchronized with this Jira Task

Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

# r+

Copy link
Contributor

@ncloudioj ncloudioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just skip the file by adding this line to tests/integration/conftest.py.

# Temporary skip for further investigation
collect_ignore = ["providers/suggest/sports/backends/test_sportsdata.py"]

@tiftran tiftran added this pull request to the merge queue Nov 25, 2025
Merged via the queue into main with commit 2542744 Nov 25, 2025
15 checks passed
@tiftran tiftran deleted the comment-out-sports branch November 25, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants