GENAI-3315 Added serverScore parameter for inferred local re-ranking - Inferred US 100% release#1219
Merged
GENAI-3315 Added serverScore parameter for inferred local re-ranking - Inferred US 100% release#1219
Conversation
mmiermans
reviewed
Mar 24, 2026
|
|
||
| TIME_ZONE_OFFSET_INFERRED_KEY = "timeZoneOffset" | ||
|
|
||
| CLICK_RANDOMIZATION_EPSILON_MICRO_FOR_EXEPRIMENT = 14700000 |
Collaborator
There was a problem hiding this comment.
Suggested change
| CLICK_RANDOMIZATION_EPSILON_MICRO_FOR_EXEPRIMENT = 14700000 | |
| CLICK_RANDOMIZATION_EPSILON_MICRO_FOR_EXPERIMENT = 14700000 |
| features={}, | ||
| # TODO - add daylight savings time check so model can switch based on daylight savings time | ||
| # Below are thresholds in 24 offset format so that results are one of current bucketed PST -> EDT | ||
| thresholds=[16.1, 17.1, 18.1], |
Collaborator
There was a problem hiding this comment.
Could these values be derived from constants in Python or a package that's already installed?
Contributor
Author
There was a problem hiding this comment.
Yes I have a todo for that above. I'll implement now
| privacy_overrides: PrivacyOverrides | None = ( | ||
| PrivacyOverridesForFivePercentExperimentUS() if small_experiment else None | ||
| ) | ||
| print("privacy overrides set " + str(privacy_overrides)) |
Collaborator
There was a problem hiding this comment.
Remove/convert debug print?
| rec.receivedRank = idx | ||
| if rescaler: | ||
| last_score = 1000.0 | ||
| tiny_delta = 0.0001 |
Collaborator
There was a problem hiding this comment.
Can you derive and/or document these values?
mmiermans
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
JIRA: https://mozilla-hub.atlassian.net/browse/GENAI-3315
Description
This PR preps for an inferred release that will work without an experiment.
• Server score is sent for most popular items to support local + server hybrid reranking (tested in an earlier experiment without the hybrid portion)
• Unknown experiments that use merino revert to local re-ranking only to preserve user privacy.
• Addition of privacy parameters override for Merino (will be enabled after future Firefox update to allow for easier experimentation)
• Use one of the inferred interests to support a special time zone offset that is handled in the client, allowing differential private time zone with inferred under the same privacy mechanism.
Background document:
https://mozilla-hub.atlassian.net/wiki/spaces/FPS/pages/2214560182/Inferred+Personalization+Rollout+to+100+in+the+US
PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)┆Issue is synchronized with this Jira Task