Skip to content

fix: Use the remote icon for dynamic wikipedia#779

Merged
ncloudioj merged 1 commit intomainfrom
disco-3196
Feb 4, 2025
Merged

fix: Use the remote icon for dynamic wikipedia#779
ncloudioj merged 1 commit intomainfrom
disco-3196

Conversation

@ncloudioj
Copy link
Copy Markdown
Contributor

@ncloudioj ncloudioj commented Feb 3, 2025

References

JIRA: DISCO-3196

Description

Now that there is Merino hosted Wikipedia icon, let's use that to replace the hardcoded one.

PR Review Checklist

Put an x in the boxes that apply

  • This PR conforms to the Contribution Guidelines
  • The PR title starts with the JIRA issue reference, format example [DISCO-####], and has the same title (if applicable)
  • [load test: (abort|skip|warn)] keywords are applied to the last commit message (if applicable)
  • Documentation has been updated (if applicable)
  • Functional and performance test coverage has been expanded and maintained (if applicable)

@ncloudioj ncloudioj requested a review from a team February 3, 2025 19:36
@ncloudioj
Copy link
Copy Markdown
Contributor Author

cc: @gruberb @Herraj. I left a TODO there so that we can dynamically provide the icon URL instead of hardcoding it in the source.

@ncloudioj ncloudioj added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 2a4196f Feb 4, 2025
4 checks passed
@ncloudioj ncloudioj deleted the disco-3196 branch February 4, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants