Conversation
misaniwere
approved these changes
Feb 10, 2025
| with TestClient(asgi_wrapper) as client: | ||
| yield client | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
could this be the reason why AMO is also failing. does the failing test also depend on this fixture?
Contributor
Author
There was a problem hiding this comment.
Yup, very likely. I checked all the latest test failures, pretty much all of them were caused by log entry assertion errors. Prior to this patch, 6 seemingly unrelated log entries were spitted out from test_manifest.py. Even so when I only ran this test file alone. Probably, there is perhaps something similar running from curated recommedation tests I guess.
DEBUG {"Timestamp": 1739221032008496896, "Type": "merino.utils.metrics", "Logger": "merino", "EnvVersion": "2.0", "Severity": 7, "Pid": metrics.py:48
66200, "Fields": {"taskName": "Task-303", "data": "merino.recommendation.prior.update.timing:17|ms|#application:merino-py,deployment.canary:0", "msg": "sending metrics"},
"severity": 100}
DEBUG {"Timestamp": 1739221032010868992, "Type": "merino.utils.metrics", "Logger": "merino", "EnvVersion": "2.0", "Severity": 7, "Pid": metrics.py:48
66200, "Fields": {"taskName": "Task-303", "data": "merino.recommendation.engagement.update.timing:21|ms|#application:merino-py,deployment.canary:0", "msg": "sending
metrics"}, "severity": 100}
INFO {"Timestamp": 1739221032013295104, "Type": "merino.utils.cron", "Logger": "merino", "EnvVersion": "2.0", "Severity": 6, "Pid": 66200, cron.py:65
"Fields": {"taskName": "Task-314", "duration": 0.026813709002453834, "msg": "Cron: successfully ran task fetch_recommendation_fakespot"}, "severity": 200}
DEBUG {"Timestamp": 1739221032089231104, "Type": "merino.utils.metrics", "Logger": "merino", "EnvVersion": "2.0", "Severity": 7, "Pid": metrics.py:48
66200, "Fields": {"taskName": "Task-303", "data": "merino.response.status_codes.200:1|c|#application:merino-py,deployment.canary:0", "msg": "sending metrics"}, "severity":
100}
DEBUG {"Timestamp": 1739221032091535104, "Type": "merino.utils.metrics", "Logger": "merino", "EnvVersion": "2.0", "Severity": 7, "Pid": metrics.py:48
66200, "Fields": {"taskName": "Task-303", "data": "merino.providers.initialize.manifest:57|ms|#application:merino-py,deployment.canary:0", "msg": "sending metrics"},
"severity": 100}
Herraj
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3226
Description
Leaking unexpected logs could cause flaky tests in Merino.
PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)