fix: update workflow not use script #1972
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taddes
changed the title
jrconlin
approved these changes
Dec 31, 2025
Member
jrconlin
left a comment
jrconlin
left a comment
There was a problem hiding this comment.
Hmm... I should book mark this for merino and other projects.
Collaborator
Author
Yeah! Let's see how it goes and then we can look at Merino and Push for you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Like some other rust services that published docs to GitHub pages, a shell script was invoked like make_book.sh in Push and Sync. Contile and Merino have similar methods. This was efficient when building docs in CircleCI, however in integrating this in Sync for the first time using GitHub Actions, it’s clear it’s inefficient in terms of debugging and error logging. Therefore, it’s better to implement the actions within the workflow commands and also increase the verbosity of the build & deploy steps for clarity.
Issue(s)
Closes STOR-443.