Show datetime in server compare (#1660)

Author: leplatrem

checks/remotesettings/server_compare.py

@@ -8,7 +8,7 @@
 """
 
 from telescope.typings import CheckResult
-from telescope.utils import run_parallel, utcnow
+from telescope.utils import run_parallel, utcfromtimestamp, utcnow
 
 from .utils import KintoClient
 
@@ -31,8 +31,18 @@ async def run(
             False,
             {
                 "monitor/changes": {
-                    "source": source_entries[0]["last_modified"],
-                    "target": target_entries[0]["last_modified"],
+                    "source": {
+                        "timestamp": source_entries[0]["last_modified"],
+                        "datetime": utcfromtimestamp(
+                            source_entries[0]["last_modified"]
+                        ).isoformat(),
+                    },
+                    "target": {
+                        "timestamp": target_entries[0]["last_modified"],
+                        "datetime": utcfromtimestamp(
+                            target_entries[0]["last_modified"]
+                        ).isoformat(),
+                    },
                 },
             },
         )
@@ -75,15 +85,21 @@ async def run(
 
         if source_metadata_timestamp != target_metadata_timestamp:
             outdated["{bucket}/{collection}".format(**entry)] = {
-                "source": source_metadata_timestamp,
-                "target": target_metadata_timestamp,
+                "source": {
+                    "timestamp": source_metadata_timestamp,
+                    "datetime": utcfromtimestamp(source_metadata_timestamp).isoformat(),
+                },
+                "target": {
+                    "timestamp": target_metadata_timestamp,
+                    "datetime": utcfromtimestamp(target_metadata_timestamp).isoformat(),
+                },
             }
 
     # Sort entries by source timestamp descending.
     outdated = dict(
         sorted(
             outdated.items(),
-            key=lambda entry: entry[1]["source"],
+            key=lambda entry: entry[1]["source"]["timestamp"],
             reverse=True,
         )
     )

tests/checks/remotesettings/test_server_compare.py

@@ -97,7 +97,18 @@ async def test_negative(mock_aioresponses):
     status, data = await run(source_url, target_url)
 
     assert status is False
-    assert data == {"bid/cid": {"target": 123, "source": 456}}
+    assert data == {
+        "bid/cid": {
+            "target": {
+                "timestamp": 123,
+                "datetime": "1970-01-01T00:00:00.123000+00:00",
+            },
+            "source": {
+                "timestamp": 456,
+                "datetime": "1970-01-01T00:00:00.456000+00:00",
+            },
+        }
+    }
 
 
 async def test_negative_monitor_outdated(mock_aioresponses):
@@ -117,4 +128,9 @@ async def test_negative_monitor_outdated(mock_aioresponses):
     status, data = await run(source_url, target_url)
 
     assert status is False
-    assert data == {"monitor/changes": {"target": 41, "source": 42}}
+    assert data == {
+        "monitor/changes": {
+            "target": {"timestamp": 41, "datetime": "1970-01-01T00:00:00.041000+00:00"},
+            "source": {"timestamp": 42, "datetime": "1970-01-01T00:00:00.042000+00:00"},
+        }
+    }