-
Notifications
You must be signed in to change notification settings - Fork 49
Add GitHub Actions linting workflow and Dockerfile #15751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5e5af2c to
88dee81
Compare
2200716 to
a4d415e
Compare
a4d415e to
009d9b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds static analysis tools for GitHub Actions workflows by introducing actionlint and zizmor linting capabilities, along with security improvements to existing workflows through action pinning and permission hardening.
- Adds Docker-based linting tools (
actionlintandzizmor) with configuration files and Makefile targets - Pins GitHub Actions to specific commit hashes for enhanced security
- Hardens workflow permissions by adding explicit permission declarations and disabling credential persistence
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| zizmor.yml | Configuration file for zizmor static analysis tool |
| docker-compose.tools.yml | Docker compose configuration for actionlint and zizmor tools |
| Makefile | Build targets for running linting tools |
| .github/workflows/transfer-issues.yml | Removes entire workflow file |
| .github/workflows/stale.yml | Adds empty permissions declaration |
| .github/workflows/docs.yml | Hardens permissions and disables credential persistence |
| .github/workflows/ci.yml | Adds action linting job and hardens security across all jobs |
| .github/dependabot.yml | Changes update interval from weekly to daily |
| .github/actions/slack/action.yml | Pins slack action to specific commit hash |
| .github/actions/slack-workflow-notification/action.yml | Adds zizmor ignore comment for unpinned action usage |
| .github/actions/pr-comment/action.yml | Refactors to use environment variables instead of direct substitution |
| .github/actions/login-gar/action.yml | Pins auth and login actions to commit hashes |
| .github/actions/login-docker/action.yml | Pins login action to commit hash |
| .github/actions/context/action.yml | Refactors to use environment variables and improves shell safety |
diox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had assigned the issue to me yesterday afternoon since nobody had it and was about to submit a very similar fix 😅
Co-authored-by: Copilot <[email protected]>
Fixes: #15744
Description
Add
actionlintandzizmorto do static analysis on our github actions defined in mozilla/addonsContext
GIthub action pins
Testing
Checklist
#ISSUENUMat the top of your PR to an existing open issue in the mozilla/addons repository.┆Issue is synchronized with this Jira Task