Skip to content

Delete suggest bench tmp dirs#6538

Merged
bendk merged 1 commit intomozilla:mainfrom
bendk:push-xzppyxsluplr
Jan 7, 2025
Merged

Delete suggest bench tmp dirs#6538
bendk merged 1 commit intomozilla:mainfrom
bendk:push-xzppyxsluplr

Conversation

@bendk
Copy link
Contributor

@bendk bendk commented Dec 30, 2024

#6479 reduced the overhead for running benchmarks, but a side effect was that it left directories filled with sqlite DBs in /tmp. This makes sure we delete those directories.

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

Branch builds: add [firefox-android: branch-name] to the PR title.

mozilla#6479 reduced the overhead for running benchmarks, but a side effect was
that it left directories filled with sqlite DBs in `/tmp`.  This makes
sure we delete those directories.
@bendk bendk requested a review from 0c0w3 December 30, 2024 22:33
Copy link
Contributor

@0c0w3 0c0w3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Sorry for the delay, I just got back today.

@bendk bendk added this pull request to the merge queue Jan 7, 2025
Merged via the queue into mozilla:main with commit 7d70184 Jan 7, 2025
15 checks passed
@bendk bendk deleted the push-xzppyxsluplr branch January 7, 2025 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants