add logins store api method add_with_record#6754
Merged
jo merged 1 commit intomozilla:mainfrom May 22, 2025
Merged
Conversation
160e078 to
5f6c439
Compare
bendk
requested changes
May 20, 2025
Contributor
bendk
left a comment
There was a problem hiding this comment.
This looks great to me. The only thing I'm really concerned about is finding a better name for RecordFields. At the very least it should be LoginRecordFields, otherwise there's a high chance for confusion or name conflicts on Swift.
The a few new method ``` fn add_with_record(&self, entry_with_record: LoginEntryWithRecordFields); fn add_many_with_records(&self, entries_with_records: Vec<LoginEntryWithRecordFields>); fn add_many(&self, entries: Vec<LoginEntry>); ``` is intended to be used during migration on desktop. This renames previously only internally used struct `RecordFields` to now exposed `LoginMeta` for clarity. Also, all structs referencing these are now called `meta` instead of `record`.
bendk
approved these changes
May 22, 2025
Contributor
bendk
left a comment
There was a problem hiding this comment.
The new names and docstrings look great to me. I think this is ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fn add_with_record(&self, entry_with_record: LoginEntryWithRecordFields): add a login together with metadatafn add_many(&self, entries: Vec<LoginEntry>): add multiple logins with single transactionfn add_many_with_records(&self, entries_with_records: Vec<LoginEntryWithRecordFields>): add multiple logins with metadata within single transactionPull Request checklist
[ci full]to the PR title.