Add ios uniffi support for context id component#6757
Merged
mhammond merged 2 commits intomozilla:mainfrom May 27, 2025
Merged
Conversation
mhammond
previously approved these changes
May 20, 2025
Member
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
This looks great to me, thanks! We aren't great with changelogs so I think not having one here seems fine.
components/context_id/uniffi.toml
Outdated
| @@ -0,0 +1,3 @@ | |||
| [bindings.swift] | |||
| ffi_module_name = "MozillaRustComponents" | |||
| ffi_module_filename = "contextIDFFI" No newline at end of file | |||
Member
There was a problem hiding this comment.
nit: please add a trailing \n here.
mergify
bot
dismissed
mhammond’s stale review
The pull request has been modified, dismissing previous reviews.
mhammond
approved these changes
May 27, 2025
Member
mhammond
left a comment
mhammond
left a comment
There was a problem hiding this comment.
Gotta love how small this is!
Member
|
/taskcluster ci full |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts the uniffi component to work with iOS so that we can expose this for the iOS App to use. There are no tests for this because it is just configuration changes! This component is already well tested. This is my first AS PR. I don't actually know if this warrants a changelog entry.
Pull Request checklist
[ci full]to the PR title.