Bug 1973636 - Add isNewUntil Search Definition to Rust Engine Selector.#6811
Merged
Standard8 merged 1 commit intomozilla:mainfrom Jul 1, 2025
Merged
Conversation
Standard8
requested changes
Jun 25, 2025
Member
Standard8
left a comment
There was a problem hiding this comment.
Thank you, this is looking good, but there's a couple of extra bits to add:
- Please add an entry to
CHANGELOG.md. Now that we are being used by multiple apps, we should be adding entries there. - Please can we extend
test_from_configuration_details_merges_variantsandtest_from_configuration_details_merges_sub_variantsto test thatis_new_untilgets properly merged.
8299a95 to
a8f27e1
Compare
Contributor
Author
|
Addressed Review comments. Oops forget to push my changes. They're in the push below this comment. After this lands, when may I land my other patch: https://phabricator.services.mozilla.com/D253104 ? |
Rust Engine Selector.
a8f27e1 to
963489a
Compare
Standard8
approved these changes
Jul 1, 2025
Member
Standard8
left a comment
There was a problem hiding this comment.
Thank you, this looks good. For landing, it'll need to be vendored across.
I'll check to see if anyone is planning to do a vendor soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
[ci full]to the PR title.