Skip to content

Bug 1973636 - Add isNewUntil Search Definition to Rust Engine Selector.#6811

Merged
Standard8 merged 1 commit intomozilla:mainfrom
mandysGit:add-isNewUntil-search-definition
Jul 1, 2025
Merged

Bug 1973636 - Add isNewUntil Search Definition to Rust Engine Selector.#6811
Standard8 merged 1 commit intomozilla:mainfrom
mandysGit:add-isNewUntil-search-definition

Conversation

@mandysGit
Copy link
Contributor

@mandysGit mandysGit commented Jun 24, 2025

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes, or
      • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
  • Quality: This PR builds and tests run cleanly
    • Note:
      • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
      • If this pull request includes a breaking change, consider cutting a new release after merging.
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
    • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
  • Dependencies: This PR follows our dependency management guidelines
    • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

@mandysGit mandysGit requested a review from Standard8 June 24, 2025 21:36
Copy link
Member

@Standard8 Standard8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is looking good, but there's a couple of extra bits to add:

  • Please add an entry to CHANGELOG.md. Now that we are being used by multiple apps, we should be adding entries there.
  • Please can we extend test_from_configuration_details_merges_variants and test_from_configuration_details_merges_sub_variants to test that is_new_until gets properly merged.

@mandysGit mandysGit force-pushed the add-isNewUntil-search-definition branch from 8299a95 to a8f27e1 Compare June 26, 2025 20:04
@mandysGit
Copy link
Contributor Author

mandysGit commented Jun 26, 2025

Addressed Review comments. Oops forget to push my changes. They're in the push below this comment.

After this lands, when may I land my other patch: https://phabricator.services.mozilla.com/D253104 ?
Would I need to wait until this code gets vendored into Mozilla Central first?

@mandysGit mandysGit force-pushed the add-isNewUntil-search-definition branch from a8f27e1 to 963489a Compare June 26, 2025 20:10
@mandysGit mandysGit requested a review from Standard8 June 27, 2025 20:38
Copy link
Member

@Standard8 Standard8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks good. For landing, it'll need to be vendored across.

I'll check to see if anyone is planning to do a vendor soon.

@Standard8 Standard8 added this pull request to the merge queue Jul 1, 2025
Merged via the queue into mozilla:main with commit 8e448a4 Jul 1, 2025
15 checks passed
@mandysGit mandysGit deleted the add-isNewUntil-search-definition branch December 11, 2025 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants