Conversation
aba5fbe to
7008bb8
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR transitions from a global rollout opt-out system to separate experiment and rollout participation controls, providing users more granular control over their participation in these different types of testing.
- Adds database migration from v2 to v3 to handle the flag change
- Replaces global participation API with separate experiment and rollout participation controls
- Exports four new UDL functions for getting/setting experiment and rollout participation separately
- Marks global participation functions as deprecated while maintaining backwards compatibility
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| components/nimbus/src/stateful/persistence.rs | Implements database migration v2→v3 and adds new participation flag keys |
| components/nimbus/src/stateful/enrollment.rs | Adds separate functions for getting/setting experiment and rollout participation |
| components/nimbus/src/stateful/nimbus_client.rs | Updates client to support separate participation controls with deprecated global fallback |
| components/nimbus/src/enrollment.rs | Introduces Participation struct and updates evolver to use separate flags |
| components/nimbus/src/nimbus.udl | Exports new participation functions via UDL interface |
| megazords/ios-rust/Sources/MozillaRustComponentsWrapper/Nimbus/Nimbus.swift | Implements iOS wrapper for new participation controls |
| components/nimbus/android/src/main/java/org/mozilla/experiments/nimbus/Nimbus.kt | Implements Android wrapper for new participation controls |
| Test files | Updates tests to use new participation model and adds migration tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
megazords/ios-rust/Sources/MozillaRustComponentsWrapper/Nimbus/NimbusApi.swift
Outdated
Show resolved
Hide resolved
megazords/ios-rust/Sources/MozillaRustComponentsWrapper/Nimbus/Nimbus.swift
Show resolved
Hide resolved
8e42356 to
35e8cc9
Compare
Member
Author
|
@freshstrangemusic Can we try to get this in again? |
c9ffceb to
c388b27
Compare
freshstrangemusic
approved these changes
Sep 3, 2025
…uts separately (#6888) - Adding db migration from v2 to v3 due to the flag change - Removing the old set_global_rollout function - Adding set_experiment and set_rollout functions - Export four new functions via UDL - get_rollouts_user_participation - set_rollouts_user_participation - get_experiments_user_participation - set_experiments_user_participation Marked `set_global_user_participation` and `get_global_user_participation` as deprecated
c388b27 to
a1892b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marked
set_global_user_participationandget_global_user_participationas deprecatedPull Request checklist
[ci full]to the PR title.