Skip to content

Monorepo build and version tweaks for nimbus-fml.#6923

Merged
mhammond merged 1 commit intomozilla:mainfrom
mhammond:push-wlzsvxzsrqul
Sep 5, 2025
Merged

Monorepo build and version tweaks for nimbus-fml.#6923
mhammond merged 1 commit intomozilla:mainfrom
mhammond:push-wlzsvxzsrqul

Conversation

@mhammond
Copy link
Member

@mhammond mhammond commented Sep 3, 2025

  • Update Cargo.toml for m-c.
  • The gradle files are modified so they work correctly in m-c.
  • Upgraded "heck" to 0.5, which required some code changes.
  • A couple other version bumps to match m-c which didn't require code changes.
  • Includes a bonus bump of rkv in nimbus itself.
  • Hacky work-arounds for the fact that the swift and kotlin tests have been broken for years
    via features. This avoids needing to vendor jsonschema into m-c, but keeps the door open
    to fixing these tests (and requiring a vendor of jsonschema) at that time.

@mhammond mhammond force-pushed the push-wlzsvxzsrqul branch 2 times, most recently from 1713a9f to b25d212 Compare September 5, 2025 15:13
* Update Cargo.toml for m-c.
* The gradle files are modified so they work correctly in m-c.
* Upgraded "heck" to 0.5, which required some code changes.
* A couple other version bumps to match m-c which didn't require code changes.
* Includes a bonus bump of rkv in nimbus itself.
* Hacky work-arounds for the fact that the swift and kotlin tests have been broken for years
  via features. This avoids needing to vendor `jsonschema` into m-c, but keeps the door open
  to fixing these tests (and requiring a vendor of jsonschema) at that time.
@mhammond mhammond marked this pull request as ready for review September 5, 2025 18:07
Copy link
Member

@freshstrangemusic freshstrangemusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs+

@mhammond mhammond added this pull request to the merge queue Sep 5, 2025
Merged via the queue into mozilla:main with commit b7f23de Sep 5, 2025
15 checks passed
@mhammond mhammond deleted the push-wlzsvxzsrqul branch September 5, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants