Bug 2004947 - Remove cargo dependency from embedded-uniffi-bindgen#7124
Merged
mhammond merged 1 commit intomozilla:mainfrom Dec 11, 2025
Merged
Bug 2004947 - Remove cargo dependency from embedded-uniffi-bindgen#7124mhammond merged 1 commit intomozilla:mainfrom
embedded-uniffi-bindgen#7124mhammond merged 1 commit intomozilla:mainfrom
Conversation
5753a4d to
6c1b8fb
Compare
Instead we do some parsing of the `Cargo.toml` files ourselves. I ran `cargo uniffi-bindgen generate -l kotlin --library ~/application-services/target/debug/libmegazord.so` with both the old and new version and the contents were identical.
6c1b8fb to
22ce06c
Compare
mhammond
approved these changes
Dec 11, 2025
Member
mhammond
left a comment
There was a problem hiding this comment.
this is great, thanks! I agree we should try and upstream this into uniffi itself, I guess behind another feature?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead we do some parsing of the
Cargo.tomlfiles ourselves. I rancargo uniffi-bindgen generate -l kotlin --library ~/application-services/target/debug/libmegazord.sowith both the old and new version and the contents were identical.Pull Request checklist
[ci full]to the PR title.