feat(ads-client): ignore context_id in HTTP cache key generation#7214
Merged
Almaju merged 1 commit intomozilla:mainfrom Feb 11, 2026
Merged
Conversation
Remove cycle_context_id() API and modify cache to ignore context_id field in request bodies when generating cache keys. This prevents unnecessary cache invalidation when context_id rotates automatically. - Remove cycle_context_id() public API (breaking change) - Strip context_id from request body before hashing for cache key - Add tests for context_id-agnostic caching behavior - Update documentation to remove cycle_context_id() method
Contributor
Author
|
@luc-lisi An idea for a not so complicated refactor instead of the quick & dirty fix: |
luc-lisi
approved these changes
Feb 11, 2026
alexcottner
pushed a commit
to alexcottner/application-services
that referenced
this pull request
Feb 11, 2026
…illa#7214) Remove cycle_context_id() API and modify cache to ignore context_id field in request bodies when generating cache keys. This prevents unnecessary cache invalidation when context_id rotates automatically. - Remove cycle_context_id() public API (breaking change) - Strip context_id from request body before hashing for cache key - Add tests for context_id-agnostic caching behavior - Update documentation to remove cycle_context_id() method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove cycle_context_id() API and modify cache to ignore context_id field in request bodies when generating cache keys. This prevents unnecessary cache invalidation when context_id rotates automatically.
Pull Request checklist
[ci full]to the PR title.