-
Notifications
You must be signed in to change notification settings - Fork 956
WT-514 - Anonym Pages In CMS #16958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dchukhin
wants to merge
40
commits into
main
Choose a base branch
from
WT-514-anonym-homepage-cms
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WT-514 - Anonym Pages In CMS #16958
+21,030
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16958 +/- ##
==========================================
+ Coverage 80.36% 80.61% +0.25%
==========================================
Files 163 164 +1
Lines 9100 9230 +130
==========================================
+ Hits 7313 7441 +128
- Misses 1787 1789 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
… need for other card types in the future
Contributor
|
CSS for these components is in progress here: #16966 |
* add an AnonymTopAndBottomPage to the project * add counter to section templates * only show icon element if icon is set * add CSS class to sections with 'top glow' theme * add table block to SectionBlocks * make sure first section heading is an h1 element, and others are h2 elements on AnonymTopAndBottomPage * update migration, since CardsListBlock.cards is now a StreamBlock, to better handle the need for other card types in the future * update body class to be anonym-specific * make sure AnonymTopAndBottomPage can be added in production * make sure AnonymTopAndBottomPage is included in db export script * make instances of AnonymTopAndBottomPage more easily identifiable by setting verbose_name
* add an AnonymTopAndBottomPage to the project * add counter to section templates * only show icon element if icon is set * add CSS class to sections with 'top glow' theme * add table block to SectionBlocks * make sure first section heading is an h1 element, and others are h2 elements on AnonymTopAndBottomPage * add an AnonymContentSubPage to the project * add toggleable items component to AnonymContentSubPage * update migration, since CardsListBlock.cards is now a StreamBlock, to better handle the need for other card types in the future * add logo cards, to allow creating case study cards on AnonymContentSubPage * update toggle to handle dark and light icons automatically * make sure migration has a license * update body class to be anonym-specific * update body class to be anonym-specific * make sure AnonymTopAndBottomPage can be added in production * make sure AnonymTopAndBottomPage is included in db export script * make sure AnonymContentSubPage can be added in production * make sure AnonymContentSubPage is included in db export script * make instances of AnonymTopAndBottomPage more easily identifiable by setting verbose_name * make instances of AnonymContentSubPage more easily identifiable by setting verbose_name
* add an AnonymTopAndBottomPage to the project * add counter to section templates * only show icon element if icon is set * add CSS class to sections with 'top glow' theme * add table block to SectionBlocks * make sure first section heading is an h1 element, and others are h2 elements on AnonymTopAndBottomPage * add an AnonymContentSubPage to the project * add toggleable items component to AnonymContentSubPage * update migration, since CardsListBlock.cards is now a StreamBlock, to better handle the need for other card types in the future * add logo cards, to allow creating case study cards on AnonymContentSubPage * update toggle to handle dark and light icons automatically * add a configurable navigation to anonym pages * make sure migration has a license * update body class to be anonym-specific * update body class to be anonym-specific * make sure AnonymTopAndBottomPage can be added in production * make sure AnonymTopAndBottomPage is included in db export script * make sure AnonymContentSubPage can be added in production * make sure AnonymContentSubPage is included in db export script * make instances of AnonymTopAndBottomPage more easily identifiable by setting verbose_name * make instances of AnonymContentSubPage more easily identifiable by setting verbose_name
* add an AnonymTopAndBottomPage to the project * add counter to section templates * only show icon element if icon is set * add CSS class to sections with 'top glow' theme * add table block to SectionBlocks * make sure first section heading is an h1 element, and others are h2 elements on AnonymTopAndBottomPage * add an AnonymContentSubPage to the project * add toggleable items component to AnonymContentSubPage * update migration, since CardsListBlock.cards is now a StreamBlock, to better handle the need for other card types in the future * add logo cards, to allow creating case study cards on AnonymContentSubPage * update toggle to handle dark and light icons automatically * add a configurable navigation to anonym pages * make sure migration has a license * update body class to be anonym-specific * update body class to be anonym-specific * add a PersonCard, to allow adding cards with people's photos to the 'About' page * add a TwoColumnBlock, to allow adding them to 'About' page * make sure AnonymTopAndBottomPage can be added in production * make sure AnonymTopAndBottomPage is included in db export script * make sure AnonymContentSubPage can be added in production * make sure AnonymContentSubPage is included in db export script * make instances of AnonymTopAndBottomPage more easily identifiable by setting verbose_name * make instances of AnonymContentSubPage more easily identifiable by setting verbose_name
* add an AnonymTopAndBottomPage to the project * add counter to section templates * only show icon element if icon is set * add CSS class to sections with 'top glow' theme * add table block to SectionBlocks * make sure first section heading is an h1 element, and others are h2 elements on AnonymTopAndBottomPage * add an AnonymContentSubPage to the project * add toggleable items component to AnonymContentSubPage * update migration, since CardsListBlock.cards is now a StreamBlock, to better handle the need for other card types in the future * add logo cards, to allow creating case study cards on AnonymContentSubPage * update toggle to handle dark and light icons automatically * add a configurable navigation to anonym pages * make sure migration has a license * update body class to be anonym-specific * update body class to be anonym-specific * add a PersonCard, to allow adding cards with people's photos to the 'About' page * add a TwoColumnBlock, to allow adding them to 'About' page * add ability to create static pages as AnonymIndexPage children * fill in content for static pages * make sure AnonymTopAndBottomPage can be added in production * make sure AnonymTopAndBottomPage is included in db export script * make sure AnonymContentSubPage can be added in production * make sure AnonymContentSubPage is included in db export script * make sure AnonymStaticPage can be added in production * make sure AnonymStaticPage is included in db export script * make sure that there is only 1 AnonymNewsPage and 1 AnonymContactPage * make instances of AnonymTopAndBottomPage more easily identifiable by setting verbose_name * make instances of AnonymContentSubPage more easily identifiable by setting verbose_name
* add an AnonymTopAndBottomPage to the project * add counter to section templates * only show icon element if icon is set * add CSS class to sections with 'top glow' theme * add table block to SectionBlocks * make sure first section heading is an h1 element, and others are h2 elements on AnonymTopAndBottomPage * add an AnonymContentSubPage to the project * add toggleable items component to AnonymContentSubPage * update migration, since CardsListBlock.cards is now a StreamBlock, to better handle the need for other card types in the future * add logo cards, to allow creating case study cards on AnonymContentSubPage * update toggle to handle dark and light icons automatically * add a configurable navigation to anonym pages * make sure migration has a license * update body class to be anonym-specific * update body class to be anonym-specific * add a PersonCard, to allow adding cards with people's photos to the 'About' page * add a TwoColumnBlock, to allow adding them to 'About' page * add ability to create static pages as AnonymIndexPage children * fill in content for static pages * make sure AnonymTopAndBottomPage can be added in production * make sure AnonymTopAndBottomPage is included in db export script * make sure AnonymContentSubPage can be added in production * make sure AnonymContentSubPage is included in db export script * make sure AnonymStaticPage can be added in production * make sure AnonymStaticPage is included in db export script * make sure that there is only 1 AnonymNewsPage and 1 AnonymContactPage * add AnonymArticlePage to project, with ability to add rich text blocks to sections * update advertising pages to pass CSS class to notification snippet * make instances of AnonymTopAndBottomPage more easily identifiable by setting verbose_name * make instances of AnonymContentSubPage more easily identifiable by setting verbose_name
* add an AnonymTopAndBottomPage to the project * add counter to section templates * only show icon element if icon is set * add CSS class to sections with 'top glow' theme * add table block to SectionBlocks * make sure first section heading is an h1 element, and others are h2 elements on AnonymTopAndBottomPage * add an AnonymContentSubPage to the project * add toggleable items component to AnonymContentSubPage * update migration, since CardsListBlock.cards is now a StreamBlock, to better handle the need for other card types in the future * add logo cards, to allow creating case study cards on AnonymContentSubPage * update toggle to handle dark and light icons automatically * add a configurable navigation to anonym pages * make sure migration has a license * update body class to be anonym-specific * update body class to be anonym-specific * add a PersonCard, to allow adding cards with people's photos to the 'About' page * add a TwoColumnBlock, to allow adding them to 'About' page * add ability to create static pages as AnonymIndexPage children * fill in content for static pages * make sure AnonymTopAndBottomPage can be added in production * make sure AnonymTopAndBottomPage is included in db export script * make sure AnonymContentSubPage can be added in production * make sure AnonymContentSubPage is included in db export script * make sure AnonymStaticPage can be added in production * make sure AnonymStaticPage is included in db export script * make sure that there is only 1 AnonymNewsPage and 1 AnonymContactPage * add AnonymArticlePage to project, with ability to add rich text blocks to sections * update advertising pages to pass CSS class to notification snippet * make instances of AnonymTopAndBottomPage more easily identifiable by setting verbose_name * make instances of AnonymContentSubPage more easily identifiable by setting verbose_name * make CMS process DRYer by updating PeopleListBlock to reference Person objects * make sure migration has a license
* add an AnonymTopAndBottomPage to the project * add counter to section templates * only show icon element if icon is set * add CSS class to sections with 'top glow' theme * add table block to SectionBlocks * make sure first section heading is an h1 element, and others are h2 elements on AnonymTopAndBottomPage * add an AnonymContentSubPage to the project * add toggleable items component to AnonymContentSubPage * update migration, since CardsListBlock.cards is now a StreamBlock, to better handle the need for other card types in the future * add logo cards, to allow creating case study cards on AnonymContentSubPage * update toggle to handle dark and light icons automatically * add a configurable navigation to anonym pages * make sure migration has a license * update body class to be anonym-specific * update body class to be anonym-specific * add a PersonCard, to allow adding cards with people's photos to the 'About' page * add a TwoColumnBlock, to allow adding them to 'About' page * make sure AnonymTopAndBottomPage can be added in production * make sure AnonymTopAndBottomPage is included in db export script * make sure AnonymContentSubPage can be added in production * make sure AnonymContentSubPage is included in db export script * make instances of AnonymTopAndBottomPage more easily identifiable by setting verbose_name * make instances of AnonymContentSubPage more easily identifiable by setting verbose_name * Initial CSS implementation * Match header style to Figma Note: This attempts to reconcile differences between the Figma design and the m24 code this was based on * Section styles Increase fidelity of section styles to match Figma * Card list styles Increase fidelity of card list styles to match Figma * Add section themes * Add stats table styles * Increase anonym homepage figma fidelity --------- Co-authored-by: Dmitriy Chukhin <6025153+dchukhin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this changeset needs to go into the FXC codebase, please add the
WMO and FXClabel.One-line summary
This pull request makes it possible to create anonym pages in Wagtail.
Significant changes and points to review
wagtail-thumbnail-choice-blocklibrarybedrock/mozorg/models.pynow has anAnonymIndexPagebedrock/mozorg/blocks/anonym.pyhas a number of blocks that can be used on theAnonymIndexPagebedrock/mozorg/templates/mozorg/cms/anonym/blocks/has template files for the new blocksmedia/css/mozorg/anonym.scsshas CSS for the anonym pages. Right now, it's just mostly icon classes mapped to their URLs, which can be moved to a different file in the futureIssue / Bugzilla link
WT-514
Testing