Conversation
flozia
force-pushed
the
lighthouse-report
branch
2 times, most recently
from
1f49dd9 to
08a0f27
Compare
|
Preview URL 🚀 : https://blurts-server-pr-5448-mgjlpikfea-uk.a.run.app |
flozia
force-pushed
the
lighthouse-report
branch
from
08a0f27 to
6ee2300
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
6ee2300 to
48602d9
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
4308555 to
c36baa9
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
c36baa9 to
f6ac651
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
f6ac651 to
802e36c
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
802e36c to
329c180
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
329c180 to
e4ce3cb
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
ef904fd to
4925549
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
c91c33d to
93be1db
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
93be1db to
9496c23
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
9496c23 to
e2164b3
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
e2164b3 to
b29f880
Compare
flozia
force-pushed
the
lighthouse-report
branch
2 times, most recently
from
cae73d7 to
d3185c5
Compare
flozia
force-pushed
the
lighthouse-report
branch
from
d3185c5 to
9ad4e73
Compare
rhelmer
approved these changes
Jan 17, 2025
rhelmer
left a comment
rhelmer
left a comment
There was a problem hiding this comment.
Changes lgtm - I believe the build failures are because we're holding off re-landing the Nimbus changes until some infra changes land, merging from main will probably resolve.
|
Cleanup completed - database 'blurts-server-pr-5448' destroyed, cloud run service 'blurts-server-pr-5448' destroyed |
Vinnl
reviewed
Feb 24, 2025
| }, | ||
| "devDependencies": { | ||
| "@faker-js/faker": "^9.3.0", | ||
| "@google-cloud/bigquery": "^7.9.1", |
Collaborator
There was a problem hiding this comment.
@flozia I see you added this dependency, which we got a dependabot PR for. Could you add a section to the docs describing how to check that the update was OK, i.e. what command to run and what results we should expect to see if successful?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References:
Jira: MNTOR-3300
Description
Record Lighthouse report results to this BiqQuery dataset.
For an example run see https://github.com/mozilla/blurts-server/actions/runs/12831312028/job/35781440079.