Delete Mozilla account at end of functional tests #6100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinnl
force-pushed
the
MNTOR-4583-moscary-functional-tests
branch
from
ae3a09f to
1ccdb82
Compare
Base automatically changed from
MNTOR-4583-moscary-functional-tests
to
main
September 11, 2025 12:16
Some tests can't be retried (in this case, deleting the account at the end of a test run), so having only a trace/video of the retry is not going to be useful to debug the actual cause of the failure.
codemist
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also changed the Playwright config to preserve videos/traces of the first run, because I was seeing failures here and wanted to debug. (It used to save the retry, but retries after deleting an account always fail.)
Unfortunately, after adding that change the test kept succeeding. Probably still a good idea to keep that option. (And I'll do another retry.)