feat(otel): opentelemetry instrumentation #6408
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Local setup for opentelemetry collection, export, and dashboards. Sentry setup for opentelemetry compatibility Convert prom-client metrics to otel metrics for HIBP requests
Avoid double-counting db queries
kschelonka
force-pushed
the
feat/otel-test
branch
from
128612b to
14c9c0a
Compare
kschelonka
force-pushed
the
feat/otel-test
branch
from
c183730 to
9ecbac3
Compare
codemist
reviewed
Jan 26, 2026
| * (e.g. used by OTEL_RESOURCE_ATTRIBUTES env var: | ||
| * 'k8s.container.name=monitor-api-endpoint,k8s.namespace.name=monitor-stage...') | ||
| * */ | ||
| export function parseKVList(str?: string): Record<string, string> { |
Collaborator
There was a problem hiding this comment.
nit: should this be in a util type folder?
codemist
reviewed
Jan 26, 2026
| import * as Sentry from "@sentry/nextjs"; | ||
|
|
||
| export async function register() { | ||
| console.log( |
Collaborator
There was a problem hiding this comment.
nit: would there be any risk of this function getting invoked more than once on reload or how the runtime boots?
codemist
reviewed
Jan 26, 2026
| - Prometheus (scrapes metrics for grafana; in GCP environment we use Google-Managed Prometheus) | ||
| - Grafana (visualization) | ||
|
|
||
| To view metrics locally, visit [Grafana](http://localhost:3000/d/monitor-dashboard/monitor?orgId=1). Some default dashboard panels are seeded. To see traces, navigate to the [Explore] pane in Grafana and select the Tempo datasource. Note that the data won't propagate immediately, so wait a minute if you're not seeing expected activity show up. |
Collaborator
There was a problem hiding this comment.
praise: Thank you for this write-up! It was helpful in explaining the process and made the setup pretty painless.
codemist
reviewed
Jan 26, 2026
| await import("./instrumentation.node"); | ||
| const { nodeSDKBuilder } = await import("./instrumentation.node"); | ||
| console.log("[INSTRUMENTATION] Initializing OTEL..."); | ||
| await nodeSDKBuilder(); |
Collaborator
There was a problem hiding this comment.
should this have a try/catch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Local setup for opentelemetry collection, export, and dashboards.
Sentry setup for opentelemetry compatibility
Convert prom-client metrics to otel metrics for HIBP requests
Example: query for a trace and failure metrics (dev environment)
How to test (local)
docker composenpm run devHow to test (dev env)
Via dev site
explorepane to search for tracesVia curl
hibp_notify_requests_total,hibp_notify_request_failures_total) (you will need to pull the dev hibp notify token in order to make successful requests)