Skip to content

Conversation

@punamdahiya
Copy link
Contributor

No description provided.

@punamdahiya punamdahiya requested a review from aminomancer March 27, 2024 21:14
Copy link
Member

@mimizillaa mimizillaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aminomancer
Copy link
Member

Should we do something about these?

npm WARN deprecated @types/[email protected]: This is a stub types definition. history provides its own type definitions, so you do not need this installed.
npm WARN deprecated [email protected]: Modern JS already guarantees Array#sort() is a stable sort, so this library is deprecated. See the compatibility table on MDN: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/sort#browser_compatibility
npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See 
https://v8.dev/blog/math-random for details.

@aminomancer
Copy link
Member

@punamdahiya you can merge if you want

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants