Don't call set_notification_runloop#178
Open
ChunMinChang wants to merge 1 commit intomozilla:trailblazerfrom
Open
Don't call set_notification_runloop#178ChunMinChang wants to merge 1 commit intomozilla:trailblazerfrom
set_notification_runloop#178ChunMinChang wants to merge 1 commit intomozilla:trailblazerfrom
Conversation
Member
Author
|
|
ChunMinChang
force-pushed
the
b1781964
branch
from
51c8a88 to
523ba1c
Compare
Collaborator
|
Yeah we don't care about super old macOS here, 10.7 is ancient. |
ChunMinChang
changed the title
set_notification_runloop on Mac OS 10.7 or later versionset_notification_runloop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix the issue mentioned in bug 1781964 comment 12 and, we should stop calling
set_notification_runloopon Mac OS 10.7