Monitor explicitly chosen output devices for liveness#186
Merged
padenot merged 3 commits intotrailblazerfrom Nov 13, 2023
Merged
Monitor explicitly chosen output devices for liveness#186padenot merged 3 commits intotrailblazerfrom
padenot merged 3 commits intotrailblazerfrom
Conversation
Testing locally on MacOS 14 there appears to be no devicechange events when the pluggable (aggregate) device used for tests is private. It seems logical that there are no devicechange events for a device that does not get exposed to other apps, and the app that created/destroyed it should know that it did, indeed, create or destroy it.
This silences a warning on nightly rustc
Contributor
Author
|
I see this is a new take on #170, well let me know what you think. |
padenot
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors what is done for input devices, and enables the output tests. This fixes cubeb's behavior with Firefox when unplugging a device that is being played to with setSinkId and that does not affect the default device (we used to always install the default-output listener and therefore changes to the default device would trigger a reinit, which would result in an error if the device no longer exists).