This repository was archived by the owner on Nov 10, 2017. It is now read-only.
Fix issue 16: Don't trigger delete requests when pressing ENTER elsewhere on the form#17
Open
graememcc wants to merge 1 commit intomozilla:masterfrom
Open
Fix issue 16: Don't trigger delete requests when pressing ENTER elsewhere on the form#17graememcc wants to merge 1 commit intomozilla:masterfrom
graememcc wants to merge 1 commit intomozilla:masterfrom
Conversation
Contributor
|
Catlee, don't suppose you could take a look at this, so we can close this out (and get closer to having 0 open issues, so can switch them off)? |
Contributor
|
Should we close this out in favour of ewong's work in PR 39? |
Contributor
|
This is about users, whereas pull request 39 is about trees, so they're unrelated aiui. |
Contributor
|
Oh yes, you're right. On Fri, Apr 5, 2013 at 10:42 AM, Ed Morley notifications@github.com wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change also decouples "Add User" from the rest of the form - I don't think it's obvious that hitting enter there will also submit any modifications you have made to existing users.