change kpi forecasts #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@irrationalagent This looks good, and should cover the changes for this repo, because you have a new yaml you'll need to modify https://github.com/mozilla/telemetry-airflow/blob/main/dags/kpi_forecasting.py as well |
Contributor
Author
|
I opened mozilla/telemetry-airflow#1534 for the airflow changes |
perrymcmanis144
suggested changes
Aug 3, 2022
Contributor
perrymcmanis144
left a comment
perrymcmanis144
left a comment
There was a problem hiding this comment.
LGTM minus the comment (let's see if adding this shows it)
jobs/kpi-forecasting/kpi-forecasting/sql_queries/desktop_qdau.sql
Outdated
Show resolved
Hide resolved
perrymcmanis144
approved these changes
Aug 3, 2022
Contributor
Author
|
@relud CI has been stuck on this since yesterday. I think it may have been because I needed to sign back into circle after the SAML switch. I've fixed that now, but I think need someone to kick it for me (I don't think I have perms to do that) |
Contributor
Author
|
I added a comment to see if i could restart the CI job |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@perrymcmanis144 am I on the right track here? I want to:
Checklist for reviewer:
referenced, the pull request should include the bug number in the title)
.circleci/config.yml) will cause environment variables (particularlycredentials) to be exposed in test logs
telemetry-airflow
responsibly.