Enterprise Felt-is-Firefox with addons by lissyx · Pull Request #10 · mozilla/enterprise-firefox

lissyx · 2025-09-04T15:44:10Z

No description provided.

gcp · 2025-09-05T07:09:03Z

Cargo.toml

 [profile.release.build-override]
 opt-level = 1

-# optimizing glsl more makes a big difference in swgl build times


This feels totally random? Merge error?

it was rebased so i need to check that

gcp · 2025-09-05T07:11:18Z

browser/extensions/felt/api.js

+
+      case "FeltParent:FirefoxAbnormalExit":
+        Services.ppmm.removeMessageListener("FeltParent:FirefoxAbnormalExit", this);
+        // TODO: What should we do, restart Firefox?


The launcher needs to do this I think to set up the IPC channel correctly.

gcp · 2025-09-05T07:11:52Z

browser/extensions/felt/api.js

+    );
+
+    if (this.feltXPCOM.isFeltUI()) {
+      this.feltXPCOM.setConsoleAddr("http://localhost:8000");


Have we thought about how to supply this in production?

Not yet, that is something I'd like we discuss next monday

Can add it to the doc so we can go over it (probably Tuesday with fiji).

One idea I had is that this is just setting a pref so it could be set at install time somehow ? ac21fc7#diff-6d0fd0afe07ce9bcbb6ddb882c13066bcbb500ab4bfcc96792c8005fd4b6fd99R375

gcp · 2025-09-05T07:12:35Z

browser/extensions/felt/background.js

+"use strict";
+
+browser.runtime.onUpdateAvailable.addListener(_details => {
+  // The New Tab built-in add-on is not designed to be updated at runtime.


New Tab? 😄

browser/extensions/felt/content/FeltParent.sys.mjs

build/mozconfig.common.enterprise

lissyx · 2025-09-09T16:16:38Z

@1rneh I'd like your review on the UI part and maybe on the tests as well

lissyx · 2025-09-09T16:16:56Z

@mkaply I'd like your review on the Live Policies changes

mkaply

A few comments, but from my perspective this looks sound as long as tests pass.

I'm going to build it locally this week.

mkaply · 2025-09-09T16:41:51Z

toolkit/components/enterprisepolicies/EnterprisePoliciesParent.sys.mjs

-            )
-          );
-        }
+  _maybeCallbackPolicy(policyImpl, parsedParameters = undefined) {


Can you comment as to what this function does?Can you add a comment as to what this function does?

This is code that was here and I moved out of the function because at some point it proved to be useful.

mkaply · 2025-09-09T16:49:04Z

toolkit/components/enterprisepolicies/EnterprisePoliciesParent.sys.mjs

    this._policies = lazy.macOSPoliciesParser.readPolicies(prefReader);
  }

+  onPoliciesChanges(handler) {


Nit, but grammatically this doesn't make sense. What exactly is changing here?

1rneh

Just some comments and questions. No blockers though, since our goal is to get this landed. But I'd like to re-visit this with a bit more time on our hands.

1rneh · 2025-09-11T06:07:48Z

browser/extensions/felt/api.js

+  addJSWindowActors(actors) {
+    this._addActors(actors, "JSWindowActor");
+  },
+};


We can use ChromeUtils.registerWindowActor in onStartUp like we do with ChromeUtils.unregisterWindowActor in onShutDown. It's not clear to me why we need to register and unregister the felt actors via preference?

That was complicated because we were depending on the matches pref and the JSWindowActor C++ code expects things to be set once. So we could not really register until we had the proper information.

With the recent evolutions, this might not be required anymore?

Yes, now we have all prefs on startup and we can register them right away.

1rneh · 2025-09-11T06:25:41Z

browser/extensions/felt/api.js

+    );
+
+    if (this.feltXPCOM.isFeltUI()) {
+      this.feltXPCOM.setConsoleAddr("http://localhost:8000");


1rneh · 2025-09-11T06:28:29Z

browser/extensions/felt/content/FeltChild.sys.mjs

+      Services.cpmm.addMessageListener("FeltMain:RedirectURL", this);
+      Services.cpmm.sendAsyncMessage("FeltChild:Loaded", {});
+    }, 0);
+  }


We can use actorCreated here, so we don't need setTimeout.

1rneh · 2025-09-11T06:36:08Z

browser/extensions/felt/content/FeltChild.sys.mjs

+      return;
+    }
+
+    this.sendAsyncMessage("FeltChild:StartFirefox", {});


We should avoid that the user sees a glimpse of the dashboard in the sso frame before we start another Firefox instance.

I think it's macOS specific as I dont get what you mean :)

I'll raise this again once I merged my UI changes.

browser/extensions/felt/content/FeltParent.sys.mjs

1rneh · 2025-09-11T07:07:29Z

browser/extensions/felt/api.js

+        Services.ppmm.removeMessageListener("FeltChild:Loaded", this);
+        const redirect_after_sso = Services.prefs.getStringPref("browser.felt.redirect_after_sso");
+        Services.ppmm.broadcastAsyncMessage("FeltMain:RedirectURL", redirect_after_sso);
+        break;


Is there a reason why FeltChild doesn't just get the preference once it receives the FeltParent:Done message? This way we could save ourselves the FeltChildLoaded and FeltMain:RedirectURL messages.

I just realized that the child never receives the message FeltParent:Done because the parent doesn't send it anywhere, so we never redirect.

Yep, I broke things at some point and the FeltParent:Done message went missing. Writing tests made me catch this.

For the prefs it's likely a consequences of the old way of fetching prefs from console. I'll see if we can simplify this right now.

Hard to promisify the http requests from rust code, and we can do those queries in places where it's easier to deal with.

Use c4d-highcpu-48 for builds Use 4d-highcpu-2 for tests

1rneh · 2025-09-11T14:45:12Z

browser/extensions/felt/api.js

+  addJSWindowActors(actors) {
+    this._addActors(actors, "JSWindowActor");
+  },
+};


Yes, now we have all prefs on startup and we can register them right away.

1rneh · 2025-09-11T14:45:25Z

browser/extensions/felt/api.js

+let JSWINDOWACTORS = {};
+
+JSWINDOWACTORS.Felt = {
+  parent: {
+    esModuleURI: "chrome://felt/content/FeltParent.sys.mjs",
+  },
+
+  child: {
+    esModuleURI: "chrome://felt/content/FeltChild.sys.mjs",
+    events: {
+      DOMContentLoaded: {},
+      load: {},
+    },
+  },
+
+  allFrames: true,
+  matches: [""],
+
+  onAddActor(register, unregister) {
+    let isRegistered = false;
+
+    const maybeRegister = () => {
+      const isEnabled = Services.prefs.getBoolPref(
+        "browser.felt.enabled",
+        false
+      );
+      if (isEnabled) {
+        JSWINDOWACTORS.Felt.matches = Services.prefs
+          .getStringPref("browser.felt.matches")
+          .split(",");
+        if (!isRegistered) {
+          register();
+          isRegistered = true;
+        }
+      } else if (isRegistered) {
+        unregister();
+        isRegistered = false;
+      }
+    };
+
+    Services.prefs.addObserver("browser.felt.enabled", maybeRegister);
+    maybeRegister();
+  },
+};
+
+let ActorManagerParent = {
+  _addActors(actors, kind) {
+    let register, unregister;
+    switch (kind) {
+      case "JSWindowActor":
+        register = ChromeUtils.registerWindowActor;
+        unregister = ChromeUtils.unregisterWindowActor;
+        break;
+      default:
+        throw new Error("Invalid JSActor kind " + kind);
+    }
+    for (let [actorName, actor] of Object.entries(actors)) {
+      // The actor defines its own register/unregister logic.
+      if (actor.onAddActor) {
+        actor.onAddActor(
+          () => register(actorName, actor),
+          () => unregister(actorName, actor)
+        );
+        continue;
+      }
+
+      // If enablePreference is set, only register the actor while the
+      // preference is set to true.
+      if (actor.enablePreference) {
+        Services.prefs.addObserver(actor.enablePreference, () => {
+          const isEnabled = Services.prefs.getBoolPref(
+            actor.enablePreference,
+            false
+          );
+          if (isEnabled) {
+            register(actorName, actor);
+          } else {
+            unregister(actorName, actor);
+          }
+          if (actor.onPreferenceChanged) {
+            actor.onPreferenceChanged(isEnabled);
+          }
+        });
+
+        if (!Services.prefs.getBoolPref(actor.enablePreference, false)) {
+          continue;
+        }
+      }
+
+      register(actorName, actor);
+    }
+  },
+
+  addJSWindowActors(actors) {
+    this._addActors(actors, "JSWindowActor");
+  },
+};


I don't see any use of enablePreference on our actors, so the whole actor registration logic can be streamlined to

registerActors() { ChromeUtils.registerWindowActor("Felt", { parent: { esModuleURI: "chrome://felt/content/FeltParent.sys.mjs", }, child: { esModuleURI: "chrome://felt/content/FeltChild.sys.mjs", events: { DOMContentLoaded: {}, load: {}, }, }, allFrames: true, matches: Services.prefs.getStringPref("browser.felt.matches").split(","), }); }

and then calling this.registerActors() instead of ActorManagerParent.addJSWindowActors(JSWINDOWACTORS); in onStartUp.

yes, now we should be able to do it. I'll look at that in a follow up, or if you want to fold it in your patches it's fine as well

1rneh · 2025-09-11T14:46:11Z

browser/extensions/felt/content/FeltChild.sys.mjs

+      return;
+    }
+
+    this.sendAsyncMessage("FeltChild:StartFirefox", {});


I'll raise this again once I merged my UI changes.

lissyx temporarily deployed to Credentials September 4, 2025 15:44 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 15:45 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 15:52 — with GitHub Actions Inactive

lissyx force-pushed the _enterprise-FELTisFirefoxWithAddons_ branch from c123214 to 8ec612e Compare September 4, 2025 15:53

lissyx temporarily deployed to Credentials September 4, 2025 15:53 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 16:02 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 16:03 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 16:04 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 16:06 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 16:07 — with GitHub Actions Inactive

lissyx force-pushed the _enterprise-FELTisFirefoxWithAddons_ branch from 8ec612e to af7e6b8 Compare September 4, 2025 16:18

lissyx temporarily deployed to Credentials September 4, 2025 16:18 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 16:35 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 16:36 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 16:38 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 16:40 — with GitHub Actions Inactive

lissyx force-pushed the _enterprise-FELTisFirefoxWithAddons_ branch from af7e6b8 to 69261eb Compare September 4, 2025 16:44

lissyx temporarily deployed to Credentials September 4, 2025 16:44 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 18:19 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 18:26 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 18:43 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 18:46 — with GitHub Actions Inactive

lissyx temporarily deployed to Credentials September 4, 2025 18:48 — with GitHub Actions Inactive

lissyx force-pushed the _enterprise-FELTisFirefoxWithAddons_ branch from c2cd2fd to f841947 Compare September 5, 2025 04:49

lissyx temporarily deployed to Credentials September 5, 2025 04:49 — with GitHub Actions Inactive

lissyx force-pushed the _enterprise-FELTisFirefoxWithAddons_ branch from f841947 to e84b61d Compare September 5, 2025 04:49

gcp approved these changes Sep 5, 2025

View reviewed changes

mkaply reviewed Sep 9, 2025

View reviewed changes

1rneh reviewed Sep 11, 2025

View reviewed changes

Alexandre Lissy added 5 commits September 11, 2025 15:37

FELT: Remove deprecated example console

2a9968b

FELT: Remove minreq dependency felt crate

727b134

Hard to promisify the http requests from rust code, and we can do those queries in places where it's easier to deal with.

FELT: Introduce RemotePoliciesProvider to handle live policies

d752727

CI: Adapt machine type for optimizing build time and costs:

ba372a4

Use c4d-highcpu-48 for builds Use 4d-highcpu-2 for tests

FELT: Add Felt UI parts as builtin extension r=gcp,yannis,fiji,mossop

0e0ec86

1rneh reviewed Sep 11, 2025

View reviewed changes

FELT: Adding FELT SSO smoke tests

cbb0217

Conversation

lissyx commented Sep 4, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

lissyx commented Sep 9, 2025

Uh oh!

lissyx commented Sep 9, 2025

Uh oh!

mkaply left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1rneh left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development