Bug 2003628 - Support Github pull requests in Enterprise Firefox#231
Bug 2003628 - Support Github pull requests in Enterprise Firefox#231ahal merged 3 commits intoenterprise-mainfrom
Conversation
ahal
force-pushed
the
ahal/enterprise-pull-requests
branch
from
2c07b47 to
06b659d
Compare
ahal
force-pushed
the
ahal/enterprise-pull-requests
branch
from
06b659d to
97b1b3e
Compare
ahal
force-pushed
the
ahal/enterprise-pull-requests
branch
from
bc58a59 to
e273c4d
Compare
ahal
force-pushed
the
ahal/enterprise-pull-requests
branch
from
e273c4d to
6bebb41
Compare
ahal
force-pushed
the
ahal/enterprise-pull-requests
branch
from
6bebb41 to
17cf714
Compare
Uh oh! Looks like an error!InterpreterError at template.tasks[1]: unknown context value isPullRequest |
There was a problem hiding this comment.
I would keep GitHub Actions around a couple of days, until we know that things are all good on TaskCluster
There was a problem hiding this comment.
Especially since we dont have yet sccache back on TaskCluster, so builds are longer (and yes it's important)
There was a problem hiding this comment.
I was just getting annoyed by all the wasted builds on my re-pushes, that's why I added DO NOT LAND ;)
| except KeyError: | ||
| pass | ||
|
|
||
| subs["project"] = get_project_alias(config) |
There was a problem hiding this comment.
do we need routes at all for PR ?
There was a problem hiding this comment.
Doesn't hurt, and just as easy to do this as it is to remove them
There was a problem hiding this comment.
ok, i was worried about index pollution, I'm not sure there's a good usecase here
…iewers To avoid polluting namespaces, pull requests use a special indexing namespace. Instead of `<project>` it is `<project>-pr`. Update gecko_taskgraph to handle this.
…viewers It's likely we'll need to handle this eventually, but for now there's no integration branches for any of the Git-based Firefox forks. So let's just always return False for the time being.
2 participants
No description provided.