Skip to content

ci: run Taskcluster tasks on all branches#259

Closed
ahal wants to merge 1 commit intoenterprise-mainfrom
ahal/push-nslnwwmmutts
Closed

ci: run Taskcluster tasks on all branches#259
ahal wants to merge 1 commit intoenterprise-mainfrom
ahal/push-nslnwwmmutts

Conversation

@ahal
Copy link
Copy Markdown
Member

@ahal ahal commented Dec 10, 2025

No description provided.

@ahal ahal self-assigned this Dec 10, 2025
@ahal ahal requested a review from lissyx December 10, 2025 17:23
@lissyx
Copy link
Copy Markdown
Contributor

lissyx commented Dec 10, 2025

Looks fine but any push to any branch will trigger build, that makes me uneasy, can we keep those branches but allow PR events? Or are things not ready yet?

@ahal
Copy link
Copy Markdown
Member Author

ahal commented Dec 11, 2025

I'm not sure why pushes to branches make you uneasy but events on PRs doesn't.. I assume they would both generate roughly the same number of tasks (pushes probably even less because many people are likely pushing to a fork).

Anyway, PRs are close.. maybe I can wrap them up today. I agree we don't really need this once we have PR events, so I can just abandon this.

@ahal ahal closed this Dec 11, 2025
@lissyx
Copy link
Copy Markdown
Contributor

lissyx commented Dec 11, 2025

I dislike the practice of directly pushing to the repo. We did it for now because private repo and credentials management on GitHub actions forced us to, but I wish we can soon all send PRs from our forks instead and sanctuarize the main repo and it's branch.

@lissyx lissyx deleted the ahal/push-nslnwwmmutts branch March 30, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants