Encode download hash in telemetry as hex string#261
Merged
gcp merged 2 commits intoenterprise-mainfrom Dec 11, 2025
Merged
Conversation
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
gcp
requested changes
Dec 10, 2025
Contributor
gcp
left a comment
gcp
left a comment
There was a problem hiding this comment.
Is it possible to add tests for this?
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
jonathanmendez
temporarily deployed
to
Credentials
GitHub Actions
Inactive
gcp
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The string returned from
getSha256Hash()was a cstring byte array. We need to encode it as hex to be valid/readable json.