Enterprise fel tis firefox with addons#5
Closed
lissyx wants to merge 12 commits intoenterprise-mainfrom
Closed
Conversation
added 12 commits
September 4, 2025 16:50
Differential Revision: https://phabricator.services.mozilla.com/D262157
Differential Revision: https://phabricator.services.mozilla.com/D262158
…ndings r=gcp,yannis,fiji,mossop Differential Revision: https://phabricator.services.mozilla.com/D254775
Differential Revision: https://phabricator.services.mozilla.com/D256087
Differential Revision: https://phabricator.services.mozilla.com/D262888
Differential Revision: https://phabricator.services.mozilla.com/D262889
lissyx
pushed a commit
that referenced
this pull request
Oct 6, 2025
…chTagScope::reacquire(). r=jandem This patch also removes explicit ip0 allocation to avoid conflicts in assumeUnreachable debug-only code, as shown in the following stack trace: ```plain-text [24036] Assertion failure: temps.IsAvailable(ScratchReg64), at D:/Workspace/gecko-dev/js/src/jit/arm64/MacroAssembler-arm64.cpp:1624 #1: js::jit::MacroAssembler::call (D:\Workspace\gecko-dev\js\src\jit\arm64\MacroAssembler-arm64.cpp:1624) #2: js::jit::MacroAssembler::callWithABINoProfiler (D:\Workspace\gecko-dev\js\src\jit\MacroAssembler.cpp:4983) #3: js::jit::MacroAssembler::assumeUnreachable (D:\Workspace\gecko-dev\js\src\jit\MacroAssembler.cpp:4038) #4: js::jit::CodeGenerator::testValueTruthyForType (D:\Workspace\gecko-dev\js\src\jit\CodeGenerator.cpp:1358) #5: js::jit::CodeGenerator::testValueTruthy (D:\Workspace\gecko-dev\js\src\jit\CodeGenerator.cpp:1477) #6: js::jit::CodeGenerator::visitTestVAndBranch (D:\Workspace\gecko-dev\js\src\jit\CodeGenerator.cpp:1927) #7: js::jit::CodeGenerator::generateBody (D:\Workspace\gecko-dev\js\src\jit\CodeGenerator.cpp:8347) #8: js::jit::CodeGenerator::generate (D:\Workspace\gecko-dev\js\src\jit\CodeGenerator.cpp:17024) #9: js::jit::CompileBackEnd (D:\Workspace\gecko-dev\js\src\jit\Ion.cpp:1696) #10: js::jit::Compile (D:\Workspace\gecko-dev\js\src\jit\Ion.cpp:2014) #11: js::jit::CanEnterIon (D:\Workspace\gecko-dev\js\src\jit\Ion.cpp:2107) #12: js::jit::MaybeEnterJit (D:\Workspace\gecko-dev\js\src\jit\Jit.cpp:202) #13: js::RunScript (D:\Workspace\gecko-dev\js\src\vm\Interpreter.cpp:462) ``` Differential Revision: https://phabricator.services.mozilla.com/D266948
lissyx
pushed a commit
that referenced
this pull request
Dec 9, 2025
Upstream commit: https://webrtc.googlesource.com/src/+/426f0590b6e4ae4541ac30fe898e5fdfcde4a7d5 Fix threading issue in "fake" (test) DescriptionObservers This fixes a problem affecting PeerConnectionWrapper and other classes using FakeSetLocalDescriptionObserver and FakeSetRemoteDescriptionObserver whereby callbacks would arrive on a different thread than the test thread. This has caused some flake in tests, but mostly has been masked by other synchronous blocking calls between the test thread and signaling thread. The pattern was that the fake observer object was being polled from the test thread until an operation completed on the signaling thread, leading to tsan errors such as detected here: https://chromium-swarm.appspot.com/task?id=735c37c9a2b00011&o=true&w=true Brief (and trimmed) example stacks: WARNING: ThreadSanitizer: data race (pid=259249) Write of size 1 at 0x721000023d70 by thread T1: ... #2 FakeSetLocalDescriptionObserver::OnSetLocalDescriptionComplete(...) #3 SdpOfferAnswerHandler::DoSetLocalDescription(...) ... #5 rtc_operations_chain_internal::OperationWithFunctor<...>::Run() #6 ChainOperation<(lambda at ../../pc/sdp_offer_answer.cc:1678:7)> #7 SdpOfferAnswerHandler::SetLocalDescription(...) ... Previous read of size 1 at 0x721000023d70 by main thread: ... #1 called pc/test/mock_peer_connection_observers.h:356:39 #2 operator() pc/peer_connection_wrapper.cc:183:3 #3 operator() test/wait_until.h:84:24 ... #6 WaitUntil(FunctionView<bool ()>, WaitUntilSettings) #7 WaitUntil<(lambda at ../../pc/peer_connection_wrapper.cc:183:3)> #8 PeerConnectionWrapper::SetLocalDescription(...) ... Bug: none Change-Id: Iadc4634fe78d5d1b252b1a3c05d7ae9c5b76922c Reviewed-on: https://webrtc-review.googlesource.com/c/src/+/409340 Reviewed-by: Danil Chapovalov <danilchap@webrtc.org> Commit-Queue: Tomas Gunnarsson <tommi@webrtc.org> Cr-Commit-Position: refs/heads/main@{#45651}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.