Skip to content

Conversation

b4handjr
Copy link
Contributor

@b4handjr b4handjr commented Aug 9, 2025

Because

  • We need to switch to using a GitHub app to push from CircleCI for any automated GitHub interactions

This commit

  • Adds the setup to use a GitHub App.

Example PR on my fork

Fixes #13206

@b4handjr b4handjr requested a review from jaredlockhart August 9, 2025 18:57
@b4handjr
Copy link
Contributor Author

b4handjr commented Aug 9, 2025

Whenever this is merged we need to delete the GH_TOKEN in our CircleCI environment variables.

Copy link
Member

@freshstrangemusic freshstrangemusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow thank you @b4handjr ! I have been wanting to do this for ages but haven't had the time.

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing incredible thank you @b4handjr 🙏 ❤️ 🎉

Comment on lines +97 to +111
setup-github-bot:
steps:
- run:
name: Install Dependencies
command: |
pip install PyJWT requests cryptography
- gh/install
- run:
name: Generate token and setup git user
command: |
export GH_TOKEN=$(python .circleci/scripts/create_jwt.py)
if [ -z "$GH_TOKEN" ]; then
echo "Failed to generate GH_TOKEN"
exit 1
fi
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow we have to do the JWT ourselves?? There isn't some client that does this for us? Wild.

@yashikakhurana
Copy link
Contributor

yashikakhurana commented Aug 11, 2025

@jaredlockhart Ben is out this week, should we merge this?

@freshstrangemusic freshstrangemusic added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit 874c04c Aug 11, 2025
15 checks passed
@freshstrangemusic freshstrangemusic deleted the fix-13206 branch August 11, 2025 17:59
freshstrangemusic added a commit that referenced this pull request Aug 12, 2025
Because:

- #13249 changed the configuration but used the wrong repository

this commit:

- updates the configuration to the use the correct repository.

Fixes #13268
github-merge-queue bot pushed a commit that referenced this pull request Aug 12, 2025
…#13269)

Because:

- #13249 changed the configuration but used the wrong repository

this commit:

- updates the configuration to the use the correct repository.

Fixes #13268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate GitHub deploy key to GitHub app
4 participants