feat(nimbus): stricter status transitions #14266
Merged
+1,039
−218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
freshstrangemusic
approved these changes
Jan 5, 2026
yashikakhurana
approved these changes
Jan 5, 2026
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
Thank you @jaredlockhart for adding this, I tried couple of scenario and seems that it is not allowing invalid states now 🎉
jaredlockhart
force-pushed
the
14227
branch
2 times, most recently
from
8677ce8 to
958fe4d
Compare
Becuase * With more experiments comes more collisions with multiple users pressing buttons quickly * We do not have strict requirements for each status transition form * This means things can be approved multiple times by multiple users concurrently * This can leave experiments in broken states if users collide * We should add strict conditions to every state transition form so a state transition can only occur once This commit * Adds required entry states for every status transition form based on the states defined in the diagrams * Updates the UI to show more detailed information if a status collision occurs * Updates tests fixes #14227
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #14227