chore(nimbus): bump minimum version to 105 #14271
Merged
+25
−481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Becuase * Remote Settings Certs were rotated and collectsion are now only readable by clients >=105 * We can bump the minimum supported version to 105 * We can remove any logic which verified versions <=105 This commit * Bumps the minimum supported version to 105 * Removes any review logic that checked for versions <=105 * Updates tests fixes #13267
jaredlockhart
requested review from
freshstrangemusic and
yashikakhurana
as code owners
Comment on lines
-1941
to
-1969
| def _validate_languages_versions(self, data): | ||
| application = data.get("application") | ||
| min_version = data.get("firefox_min_version", "") | ||
|
|
||
| if data.get("languages", []): | ||
| min_supported_version = ( | ||
| NimbusConstants.LANGUAGES_APPLICATION_SUPPORTED_VERSION[application] | ||
| ) | ||
| if NimbusExperiment.Version.parse( | ||
| min_version | ||
| ) < NimbusExperiment.Version.parse(min_supported_version): | ||
| raise serializers.ValidationError( | ||
| { | ||
| "languages": f"Language targeting is not \ | ||
| supported for this application below \ | ||
| version {min_supported_version}" | ||
| } | ||
| ) | ||
| return data | ||
|
|
||
| def _validate_countries_versions(self, data): | ||
| application = data.get("application") | ||
| min_version = data.get("firefox_min_version", "") | ||
|
|
||
| if data.get("countries", []): | ||
| min_supported_version = ( | ||
| NimbusConstants.COUNTRIES_APPLICATION_SUPPORTED_VERSION[application] | ||
| ) | ||
| if NimbusExperiment.Version.parse( |
Contributor
There was a problem hiding this comment.
dont we want to keep this validation check @jaredlockhart 🤔
Collaborator
Author
There was a problem hiding this comment.
No these checks all checked for things below version 105, which is now the minimum, so they're not necessary anymore.
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
I have question about the validation checks for languages locales and countries
yashikakhurana
approved these changes
Jan 6, 2026
Contributor
yashikakhurana
left a comment
yashikakhurana
left a comment
There was a problem hiding this comment.
perfect, thank you @jaredlockhart for explaining it that too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Becuase
This commit
fixes #13267