chore(nimbus): replace GraphQL with form POSTs in integration test helpers#14841
Closed
jaredlockhart wants to merge 1 commit intomainfrom
Closed
chore(nimbus): replace GraphQL with form POSTs in integration test helpers#14841jaredlockhart wants to merge 1 commit intomainfrom
jaredlockhart wants to merge 1 commit intomainfrom
Conversation
…lpers Because * The GraphQL API is being removed from experimenter * The integration tests use GraphQL mutations to create, update, and end experiments, and GraphQL queries for config and experiment data * All of this functionality already exists in the Django form views and REST API endpoints This commit * Rewrites helpers.py to POST directly to Django form views instead of using GraphQL mutations for experiment CRUD * Reads experiment data via the v6 REST API instead of GraphQL queries * Generates feature config IDs to JSON (extending the targeting configs management command) instead of querying them via GraphQL * Adds DISABLE_CSRF env var support to skip CSRF middleware in CI * Removes all GraphQL query/mutation code from the integration test helpers Fixes #14839 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jaredlockhart
requested review from
freshstrangemusic,
mikewilli,
relud and
yashikakhurana
as code owners
Collaborator
Author
|
Superseded — splitting into separate PR on top of #14815 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
experiments, and GraphQL queries for config and experiment data
REST API endpoints
This commit
helpers.pyto POST directly to Django form views (/nimbus/create/,/nimbus/{slug}/update_branches/,/nimbus/{slug}/update_audience/, etc.)instead of using GraphQL mutations
/api/v6/experiments/{slug}/and/api/v6/draft-experiments/{slug}/) instead of GraphQL queriescommand) instead of querying via GraphQL
DISABLE_CSRFenv var support to skip CSRF middleware in CIFixes #14839