Skip to content

feat(nimbus):Removes question emoji if the request is cancelled#15000

Merged
yashikakhurana merged 2 commits intomainfrom
14972
Mar 20, 2026
Merged

feat(nimbus):Removes question emoji if the request is cancelled#15000
yashikakhurana merged 2 commits intomainfrom
14972

Conversation

@yashikakhurana
Copy link
Contributor

Because

  • We add a question emoji if the request is review pending, but user can cancel the request so in that case we should remove the pending review question emoji so it is easy for reviewers to know which request is cancelled and which is pending for the review

This commit

  • Removes the question emoji if the request is cancelled

Fixes #14972

Copy link
Collaborator

@jaredlockhart jaredlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a perfect PR. Our patterns are getting so so so nice to modify and review. This reads beautifully. 14/10 A+++ would R+ again ty @yashikakhurana 🙏 🎉

@yashikakhurana yashikakhurana added this pull request to the merge queue Mar 20, 2026
Merged via the queue into main with commit fd3beca Mar 20, 2026
31 checks passed
@yashikakhurana yashikakhurana deleted the 14972 branch March 20, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove question mark when review request is canceled

2 participants