feat(nimbus): Add a test that loads all FML manifests#15090
Merged
freshstrangemusic merged 1 commit intomainfrom Mar 31, 2026
Merged
feat(nimbus): Add a test that loads all FML manifests#15090freshstrangemusic merged 1 commit intomainfrom
freshstrangemusic merged 1 commit intomainfrom
Conversation
freshstrangemusic
requested review from
jaredlockhart,
mikewilli,
relud and
yashikakhurana
as code owners
freshstrangemusic
force-pushed
the
freshstrangemusic/push-vxlnzootnlmm
branch
4 times, most recently
from
ae280f1 to
edc92ff
Compare
Because: - we are constantly adding and updating feature manifests; - we are constantly updating our application-services dependency; and - we have no tests that validate that existing manifests are valid in these cases this commit: - adds a test case per application that validates the vendored FML files are loadable. Fixes #15020
freshstrangemusic
force-pushed
the
freshstrangemusic/push-vxlnzootnlmm
branch
from
edc92ff to
24fb631
Compare
jaredlockhart
approved these changes
Mar 31, 2026
Collaborator
jaredlockhart
left a comment
jaredlockhart
left a comment
There was a problem hiding this comment.
Awesome ty beth 🙏 I can't believe they're so fast XD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
this commit:
Fixes #15020