Merge pull request #460 from mozilla/as/adjust-server-not-found-error-test

Anca/Fix server not found error

Author: Tracy-Walker

tests/address_bar_and_search/test_server_not_found_error.py

@@ -13,13 +13,13 @@ def test_case():
     return "1901393"
 
 
-CHECK_SITE = "http://cnn"
+CHECK_SITE = "http://example"
 SHORT_SITE = CHECK_SITE.split("/")[-1]
 
 ERROR_TITLES = ["Hmm. We’re having trouble finding that site."]
 
 
-def test_server_not_found_error(driver: Firefox):
+def test_server_not_found_error(driver: Firefox, version: str):
     """
     C1901393: - This tests that when a user navigates to a non-existent site, a "Server Not Found" error is
     displayed. The error page contains the correct elements, and the suggested link redirects to the appropriate page.
@@ -30,6 +30,9 @@ def test_server_not_found_error(driver: Firefox):
     tabs = TabBar(driver)
     error_page = ErrorPage(driver)
 
+    # Auto-detect if this is a Nightly build by checking the version string
+    is_nightly = any(identifier in version.lower() for identifier in ["a1", "nightly"])
+
     nav.search(CHECK_SITE)
 
     # Verify the tab title
@@ -38,35 +41,37 @@ def test_server_not_found_error(driver: Firefox):
     )
 
     # Verify elements on the error page
-    error_title = error_page.get_error_title()
-    assert (
-        error_title in ERROR_TITLES
-    ), f"Expected error title text not found. Actual: {error_title}"
-
-    error_short_description = error_page.get_error_short_description()
+    assert error_page.get_error_title() in ERROR_TITLES
     assert (
-        f"We can’t connect to the server at {SHORT_SITE}" in error_short_description
-    ), (
-        f"Expected error short description text not found."
-        f"Actual: {error_short_description}"
+        f"We can’t connect to the server at {SHORT_SITE}"
+        in error_page.get_error_short_description()
     )
 
-    error_long_description_items = error_page.get_error_long_description_items()
+    # Set the permission text based on what version is actually running
+    if is_nightly:
+        permission_message = (
+            "Check that Nightly has permission to access the web (you might be connected but behind "
+            "a firewall)"
+        )
+    else:
+        permission_message = (
+            "Check that Firefox has permission to access the web (you might be connected but behind "
+            "a firewall)"
+        )
+
     expected_texts = [
         "Try again later",
         "Check your network connection",
-        "Check that Firefox has permission to access the web (you might be connected but behind a firewall)",
+        permission_message,
     ]
 
-    for i, item in enumerate(error_long_description_items):
-        assert (
-            item.text == expected_texts[i]
-        ), f"Expected error long description item text not found. Actual: {item.text}"
+    for i, item in enumerate(error_page.get_error_long_description_items()):
+        assert item.text == expected_texts[i]
 
     WebDriverWait(driver, 30).until(
         lambda d: error_page.get_try_again_button().is_displayed()
     )
 
     # Verify that the suggested link redirects to the correct page
     error_page.get_error_suggestion_link().click()
-    nav.expect_in_content(EC.url_contains("https://www.cnn.com/"))
+    nav.expect_in_content(EC.url_contains("https://www.example.com/"))