Merge pull request #124 from mozilla/sl/firefox-never-rmb-history

Firefox Private Browsing Never Remember History

Author: sarinali

modules/data/about_prefs.components.json

@@ -321,5 +321,35 @@
         "selectorData": "primaryBrowserLocale",
         "strategy": "id",
         "groups": []
+    },
+
+    "cookies-privacy-label": {
+        "selectorData": "description[data-l10n-id='sitedata-delete-on-close-private-browsing2']",
+        "strategy": "css",
+        "groups": []
+    },
+
+    "cookies-delete-on-close": {
+        "selectorData": "deleteOnClose",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "logins-ask-to-save-password": {
+        "selectorData": "savePasswords",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "logins-exceptions": {
+        "selectorData": "passwordExceptions",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "history-privacy-label": {
+        "selectorData": "description[data-l10n-id='history-dontremember-description']",
+        "strategy": "css",
+        "groups": []
     }
 }

modules/data/panel_ui.components.json

@@ -131,6 +131,18 @@
         "selectorData": "#appMenu_historyMenu .toolbarbutton-text",
         "strategy": "css",
         "groups": []
+    },
+
+    "panel-ui-history-recent-history-container": {
+        "selectorData": "appMenu_historyMenu",
+        "strategy": "id",
+        "groups": []
+    },
+
+    "panel-ui-history-recent-history-item": {
+        "selectorData": "toolbarbutton",
+        "strategy": "tag",
+        "groups": []
     }
 
 }

tests/security_and_privacy/test_never_remember_browsing_history.py

@@ -0,0 +1,89 @@
+import pytest
+from selenium.webdriver import Firefox
+
+from modules.browser_object import PanelUi, TabBar
+from modules.page_object_about_prefs import AboutPrefs
+
+links = [
+    "about:about",
+    "about:addons",
+    "about:cache",
+    "about:config",
+    "about:buildconfig",
+    "about:robots",
+    "about:blank",
+]
+
+COOKIE_LABEL_TEXT = "Based on your history settings, Firefox deletes cookies and site data from your session when you close the browser."
+HISTORY_LABEL_TEXT = "Firefox will use the same settings as private browsing, and will not remember any history as you browse the Web."
+
+
+@pytest.fixture()
+def add_prefs():
+    return [("browser.privatebrowsing.autostart", True)]
+
+
+def test_never_remember_browsing_history_settings(driver: Firefox):
+    """
+    C102381.1: Ensure that setting the browser to never remember history has the correct configurations in about:preferences
+    """
+    # instantiate objs
+    about_prefs = AboutPrefs(driver, category="privacy").open()
+
+    # perform all about:preferences#privacy assertions according to testrail
+    cookies_label = about_prefs.get_element("cookies-privacy-label")
+    assert cookies_label.get_attribute("innerHTML") == COOKIE_LABEL_TEXT
+
+    delete_cookies_checkbox = about_prefs.get_element("cookies-delete-on-close")
+    assert delete_cookies_checkbox.get_attribute("checked") == "true"
+
+    save_password = about_prefs.get_element("logins-ask-to-save-password")
+    assert save_password.get_attribute("checked") is None
+
+    login_exceptions = about_prefs.get_element("logins-exceptions")
+    assert login_exceptions.get_attribute("disabled") == "true"
+
+    history_label = about_prefs.get_element("history-privacy-label")
+    assert history_label.get_attribute("innerHTML") == HISTORY_LABEL_TEXT
+
+
+def test_never_remember_browsing_history_from_panel(driver: Firefox):
+    """
+    C102381.2: Ensure that setting the browser to never remember history does not actually save any history
+    """
+    panel_ui = PanelUi(driver).open()
+    tabs = TabBar(driver)
+    # util = Utilities()
+
+    num_tabs = 6
+
+    # open some tabs
+    for i in range(num_tabs):
+        driver.get(links[i])
+        tabs.new_tab_by_button()
+        tabs.switch_to_new_tab()
+
+    # close the first 6 tabs
+    with driver.context(driver.CONTEXT_CHROME):
+        x_icon = tabs.get_element("tab-x-icon", multiple=True)
+        for i in range(num_tabs):
+            x_icon[i].click()
+
+        panel_ui.open_panel_menu()
+
+        # go into the history tab
+        panel_ui.get_element("panel-ui-history").click()
+
+        # check for history
+        recently_visited_container = panel_ui.get_element(
+            "panel-ui-history-recent-history-container"
+        )
+        recently_visited_items = panel_ui.get_element(
+            "panel-ui-history-recent-history-item",
+            multiple=True,
+            parent_element=recently_visited_container,
+        )
+
+        # ensure no actual items are there
+        assert len(recently_visited_items) == 1
+        assert recently_visited_items[0].get_attribute("label") == "(Empty)"