get rid of get element

Author: Hani Yacoub

tests/password_manager/test_about_logins_navigation_from_context_menu.py

@@ -26,8 +26,7 @@ def test_about_logins_navigation_from_login_form_context_menu(driver: Firefox):
 
     # Access the manage passwords in context menu from the username field in the demo login form
     login.open()
-    username_field = login.get_element("username-field")
-    login.context_click(username_field)
+    login.context_click("username-field")
     context_menu.click_and_hide_menu("context-menu-manage-passwords")
 
     # Verify that the about:logins page is opened in a new tab

tests/password_manager/test_auto_saved_generated_password_context_menu.py

@@ -16,6 +16,9 @@ def add_to_prefs_list():
     return [("signon.rememberSignons", True)]
 
 
+UPDATE_DOORHANGER_TEXT = "Update password for mozilla.github.io?"
+
+
 def test_auto_saved_generated_password_context_menu(driver: Firefox):
     """
     C2248176 - Securely Generated Password is auto-saved when generated from password field context menu
@@ -43,7 +46,7 @@ def test_auto_saved_generated_password_context_menu(driver: Firefox):
         update_doorhanger = autofill_popup_panel.get_element(
             "password-update-doorhanger"
         )
-        assert update_doorhanger.text == "Update password for mozilla.github.io?"
+        assert update_doorhanger.text == UPDATE_DOORHANGER_TEXT
 
     # Navigate to about:logins page
     tabs.switch_to_new_tab()

tests/password_manager/test_can_view_password_when_PP_enabled.py

@@ -16,7 +16,7 @@ def test_password_can_be_shown(driver: Firefox):
     """
     C2264688: Verify that the Show Password button prompts for the Primary Password before revealing the saved login
     """
-    # instantiate object
+    # Instantiate object
     about_logins = AboutLogins(driver)
     about_prefs = AboutPrefs(driver, category="privacy")
     ba = BrowserActions(driver)

tests/password_manager/test_changes_made_in_edit_mode_are_saved.py

@@ -13,7 +13,7 @@ def test_changes_made_in_edit_mode_are_saved(driver: Firefox):
     """
     C2241121 - Verify that changes made in Edit Mode are saved
     """
-    # instantiate object
+    # Instantiate object
     about_logins = AboutLogins(driver)
 
     # Open about:logins and add a new login

tests/password_manager/test_saved_hyperlink_redirects_to_corresponding_page.py

@@ -38,7 +38,7 @@ def test_saved_hyperlink_redirects_to_corresponding_page(driver: Firefox):
     )
 
     # Click on the hyperlink website
-    about_logins.get_element("website-address").click()
+    about_logins.click_on("website-address")
     about_logins.switch_to_new_tab()
     about_logins.url_contains("mozilla.github")
 

tests/password_manager/test_update_login_via_doorhanger.py

@@ -61,6 +61,8 @@ def test_update_login_via_doorhanger(driver: Firefox):
     # Select Reveal password from password field context menu for headed run purpose only
     password_field = login_autofill.get_element("password-login-field")
     login_autofill.context_click(password_field)
+    # login_autofill.context_click("password-login-field")
+
     context_menu.click_and_hide_menu("context-menu-reveal-password")
 
     # Verify the password matches updated password value