Skip to content

Hani/ test add bookmark folder toolbar not saving realtime #1071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sv-hyacoub wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Hani/ test add bookmark folder toolbar not saving realtime #1071

sv-hyacoub wants to merge 13 commits into from

Conversation

@sv-hyacoub
Copy link
Collaborator

@sv-hyacoub sv-hyacoub commented Feb 10, 2026 •
edited
Loading

Relevant Links

Bugzilla: 2009737
TestRail: 2090451

Description of Code / Doc Changes

  • Add test to verify that adding a Bookmark Folder from the Bookmarks Toolbar will not save changes in real time.

Process Changes Required

Mark the relevant boxes, delete irrelevant lines.

  • Adds a dependency (rerun pipenv install)
  • Modifies a git hook (rerun ./devsetup.sh)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

N/A

Comments or Future Work

N/A

Workflow Checklist

  • Reviewers have been requested.
  • Code has been linted and formatted.
  • If this is an unblocker, a message has been posted to #dte-automation in Slack.

Thank you!

ben-c-at-moz
ben-c-at-moz requested changes Feb 11, 2026
View reviewed changes
Copy link
Collaborator

@ben-c-at-moz ben-c-at-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one tiny thing, but otherwise great

ben-c-at-moz
ben-c-at-moz previously approved these changes Feb 12, 2026
View reviewed changes
Copy link
Collaborator

@ben-c-at-moz ben-c-at-moz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I merged the lint fixes into main, then merged main into here

@ben-c-at-moz ben-c-at-moz self-requested a review February 12, 2026 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben-c-at-moz ben-c-at-moz ben-c-at-moz approved these changes

@soncuteanca soncuteanca Awaiting requested review from soncuteanca

@vsangereanMOZ vsangereanMOZ Awaiting requested review from vsangereanMOZ

@Tracy-Walker Tracy-Walker Awaiting requested review from Tracy-Walker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sv-hyacoub @ben-c-at-moz