Skip to content

Philimon/ebay_gb_and_it #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jul 31, 2025
Merged

Philimon/ebay_gb_and_it #681

merged 23 commits into from
Jul 31, 2025

Conversation

@philimon-reset
Copy link
Collaborator

@philimon-reset philimon-reset commented Jul 25, 2025 •
edited
Loading

Relevant Links

Description of Code / Doc Changes

  • add eBay GB and IT.
  • ebay GB address tests skipped for Linux (very flaky for one or two tests for linux headed, same as amazon US)
    • the tests pass locally so the issue must be in how headed tests are set up in linux gha
  • IT address autofill feature is not available yet so address tests are skipped.

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@philimon-reset philimon-reset self-assigned this Jul 25, 2025
Tracy-Walker
Tracy-Walker previously approved these changes Jul 29, 2025
View reviewed changes
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Tracy-Walker
Copy link
Collaborator

Tracy-Walker commented Jul 31, 2025

Both of the smoketests that fail in CI, on Windows here, PASSED for me on my local Windows machine in this branch. As such, I don't think anything in this PR is the cause for those two failures. Either have Ben push this through, or skipif "Win" the two tests and file bugs for followup investigation of each of the failing tests.

@philimon-reset philimon-reset merged commit 6caeb92 into main Jul 31, 2025
24 checks passed
@ben-c-at-moz ben-c-at-moz deleted the philimon/ebay_it branch September 2, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben-c-at-moz ben-c-at-moz ben-c-at-moz approved these changes

@soncuteanca soncuteanca Awaiting requested review from soncuteanca

@Tracy-Walker Tracy-Walker Awaiting requested review from Tracy-Walker

Assignees

@philimon-reset philimon-reset

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@philimon-reset @Tracy-Walker @ben-c-at-moz