Skip to content

Anca/ Active tab test stabilization #688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025
Merged

Anca/ Active tab test stabilization #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion modules/testrail_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,12 @@ def organize_l10n_entries(
if not test_results[category].get(run_id):
test_results[category][run_id] = []
test_results[category][run_id].append(
{"suite_id": suite_id, "site": site, "test_case": test_case, "duration": f"{duration}s"}
{
"suite_id": suite_id,
"site": site,
"test_case": test_case,
"duration": f"{duration}s",
}
)

return test_results
Expand Down
11 changes: 6 additions & 5 deletions tests/tabs/test_active_tab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,15 @@ def test_active_tab(driver: Firefox):
tabs = TabBar(driver)
num_tabs = 5

# opening 5 tabs
# Open 5 tabs
for i in range(num_tabs):
tabs.new_tab_by_button()

# go through all the tabs and ensure highlighted one is correct, +2 since 1 indexed and additional tab for the beginning
# Go through all the tabs and ensure the focus is correct
for i in range(1, num_tabs + 2):
target_tab = tabs.get_tab(i)
with driver.context(driver.CONTEXT_CHROME):
target_tab = tabs.get_tab(i)
target_tab.click()
visibility = target_tab.get_attribute("visuallyselected")
assert visibility == ""
tabs.custom_wait(timeout=3).until(
lambda d: target_tab.get_attribute("visuallyselected") == ""
)
Loading