Skip to content

Conversation

@sv-hyacoub
Copy link
Collaborator

@sv-hyacoub sv-hyacoub commented Jul 29, 2025

Relevant Links

Bugzilla: 1979887

Description of Code / Doc Changes

Added [DE] Justspices page and locators for address and credit card.
CC is in an iframe can't be used.

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

Copy link
Collaborator

@soncuteanca soncuteanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minify the HTML pages.

@sv-hyacoub
Copy link
Collaborator Author

Minify the HTML pages.

I minified both files.

@soncuteanca soncuteanca self-requested a review July 29, 2025 14:00
@soncuteanca soncuteanca changed the title Hani/ L10n [US] Justspices (ad + cc) Hani/ L10n [DE] Justspices (ad + cc) Jul 29, 2025
Copy link
Collaborator

@soncuteanca soncuteanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@sv-hyacoub sv-hyacoub merged commit a834ec6 into main Jul 29, 2025
11 checks passed
@sv-hyacoub sv-hyacoub deleted the Hani/cm-justspices-de branch July 29, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants