Skip to content

Hani/ L10n [ES] Zooplus #715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 12, 2025
Merged

Hani/ L10n [ES] Zooplus #715

merged 5 commits into from
Aug 12, 2025

Conversation

sv-hyacoub
Copy link
Collaborator

@sv-hyacoub sv-hyacoub commented Aug 11, 2025

Relevant Links

Bugzilla: 1981971
TestRail: N/A

Description of Code / Doc Changes

Added [ES] Zooplus page and locators for address.
CC is in an iframe, can't be captured.

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@sv-hyacoub sv-hyacoub changed the title Anca/ L10n [ES] Zooplus Hani/ L10n [ES] Zooplus Aug 11, 2025
@soncuteanca soncuteanca self-requested a review August 11, 2025 12:25
soncuteanca
soncuteanca previously approved these changes Aug 11, 2025
Copy link
Collaborator

@soncuteanca soncuteanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, all tests passed locally.

soncuteanca
soncuteanca previously approved these changes Aug 11, 2025
Copy link
Collaborator

@soncuteanca soncuteanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc_html supposed to have empty body?

@sv-hyacoub
Copy link
Collaborator Author

cc_html supposed to have empty body?

It's empty body since CC is in an iframe and can't be captured.

@sv-hyacoub sv-hyacoub requested a review from soncuteanca August 12, 2025 09:03
Copy link
Collaborator

@soncuteanca soncuteanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sv-hyacoub sv-hyacoub merged commit 8fb4410 into main Aug 12, 2025
18 checks passed
@sv-hyacoub sv-hyacoub deleted the Hani/cm-zooplus-es branch August 12, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants