-
Notifications
You must be signed in to change notification settings - Fork 12
Hani/ L10n [ES] Zooplus #715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, all tests passed locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc_html supposed to have empty body?
It's empty body since CC is in an iframe and can't be captured. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Relevant Links
Bugzilla: 1981971
TestRail: N/A
Description of Code / Doc Changes
Added [ES] Zooplus page and locators for address.
CC is in an iframe, can't be captured.
Process Changes Required
Mark the relevant boxes:
pipenv install
)Screenshots or Explanations
If you need to explain your code, do it here.
Comments or Future Work
Do we need to start another PR soon to address something you saw while working on this?
Workflow Checklist
Thank you!