tracy/Enable middle click in either context #730
Merged
+27
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
unrelated random smoketest failure on Linux. (it didn't even rerun the failed test: notifications/test_webextension_completed_installation_successfully_displayed.py) |
|
Totally unrelated failure on Linux L10n. Asking for review and approval, so I can push this through. I already have a fix in hand for the notifications test failure on Linux. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Links
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1982874
Disable failing Linux test - https://bugzilla.mozilla.org/show_bug.cgi?id=1983280
Description of Code / Doc Changes
Minor change to middle_click() method to allow it to work in content and chrome contexts.
Lint did some white space maneuvering
Process Changes Required
Future work
I'll investigate then fix the Linux notifications test failure as part of a new PR
Workflow Checklist