Skip to content

tracy/Re-enable and fix some tests #759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2025
Merged

tracy/Re-enable and fix some tests #759

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/address_bar_and_search/test_default_search_provider_change_awesome_bar.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
from platform import system

import pytest
from selenium.webdriver import Firefox

from modules.browser_object import Navigation
from modules.page_object import AboutPrefs

WAIT_TIMEOUT = 10
SEARCH_ENGINE = "DuckDuckGo"
EXPECTED_PLACEHOLDER = f"Search with {SEARCH_ENGINE} or enter address"

Expand All @@ -14,7 +15,7 @@ def test_case():
return "3028795"


@pytest.mark.unstable(reason="Bug 1983836")
@pytest.mark.skipif(system().lower().startswith("win"), reason="Bug 1983836")
@pytest.mark.ci
def test_default_search_provider_change_awesome_bar(driver: Firefox):
"""
Expand Down
1 change: 0 additions & 1 deletion tests/preferences/test_lang_pack_changed_from_about_prefs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def add_to_prefs_list():
return [("services.sync.prefs.sync-seen.intl.accept_languages", True)]


@pytest.mark.unstable(reason="Bug 1978598")
def test_lang_pack_changed_from_about_prefs(driver: Firefox):
"""
C1771617 - The language can be changed in about:preferences.
Expand Down
1 change: 0 additions & 1 deletion tests/security_and_privacy/test_downloads_from_private_not_leaked.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def delete_files_regex_string():
return r"opm.*\.pdf"


@pytest.mark.unstable(reason="Bug 1983849")
@pytest.mark.slow
@pytest.mark.audio
def test_downloads_from_private_not_leaked(driver: Firefox, delete_files, screenshot):
Expand Down
5 changes: 4 additions & 1 deletion tests/tabs/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,10 @@ def suite_id():
@pytest.fixture()
def prefs_list(add_to_prefs_list: dict):
"""List of prefs to send to main conftest.py driver fixture"""
prefs = [("browser.tabs.delayHidingAudioPlayingIconMS", "200")]
prefs = [
("browser.tabs.delayHidingAudioPlayingIconMS", "200"),
("browser.toolbars.bookmarks.visibility", "always"),
]
prefs.extend(add_to_prefs_list)
return prefs

Expand Down
1 change: 1 addition & 0 deletions ..._history/test_open_bookmark_in_new_tab.py → tests/tabs/test_open_bookmark_in_new_tab.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ def test_open_bookmark_in_new_tab(driver: Firefox):

# In a new tab, right-click the bookmarked page in the toolbar and select Open in New Tab from the context menu
tabs.new_tab_by_button()
tabs.wait_for_num_tabs(2)
nav.open_bookmark_in_new_tab_via_context_menu(BOOKMARK_TITLE)

# Verify that the test page is opened in a new normal tab
Expand Down
Loading