Skip to content

Conversation

@ben-c-at-moz
Copy link
Collaborator

@ben-c-at-moz ben-c-at-moz commented Sep 17, 2025

Relevant Links

Bugzilla: Link

Description of Code / Doc Changes

  • Reenable test
  • Add method to check if theme color is "close enough" to the key

Process Changes Required

None

Screenshots or Explanations

The current AboutAddons.activate_theme contains a perform_assert check to ensure that the theme was applied successfully. We need to not do that so we can use our "close enough" method.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

I think it would be worthwhile to consider removing the theme color assertion in AboutAddons.activate_theme() and update all relevant tests.

Workflow Checklist

  • Please request reviewers
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

@ben-c-at-moz ben-c-at-moz changed the title PLZ IGNORE get color values for all bgs get color values for all bgs Sep 19, 2025
@Tracy-Walker Tracy-Walker self-requested a review September 19, 2025 17:57
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ben-c-at-moz ben-c-at-moz merged commit f1eca20 into main Sep 19, 2025
15 checks passed
@ben-c-at-moz ben-c-at-moz deleted the ben/stabilize-themes branch September 19, 2025 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants