-
Notifications
You must be signed in to change notification settings - Fork 15
Create Test for Play/Mute/Unmute Tabs Toggle #814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Test for Play/Mute/Unmute Tabs Toggle #814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please try removing maximize_window(). I'm very curious to see if doing so fixes this on GHA runs.
Removed window maximization before opening video links.
Disable test on GHA
Tracy-Walker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe update each sleep to a CONSTANT for each, for easier adjustment. I disabled the test on GHA (MAc and Windows). Will need to file a follow up bug to investigate later.
Tracy-Walker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Well done.
Relevant Links
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1987739
TestRail: 246981
Description of Code / Doc Changes
Leave a bullet-pointed list of changes you made.
Created a test to verify that the toggle button to play/mute/unmute multiple tabs works correctly.
Process Changes Required
Mark the relevant boxes:
pipenv install)Screenshots or Explanations
If you need to explain your code, do it here.
Comments or Future Work
Do we need to start another PR soon to address something you saw while working on this?
Workflow Checklist
Thank you!