Skip to content

Conversation

@krishpdev
Copy link
Collaborator

Relevant Links

Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1987739
TestRail: 246981

Description of Code / Doc Changes

Leave a bullet-pointed list of changes you made.

Created a test to verify that the toggle button to play/mute/unmute multiple tabs works correctly.

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please try removing maximize_window(). I'm very curious to see if doing so fixes this on GHA runs.

@Tracy-Walker Tracy-Walker self-requested a review October 23, 2025 21:04
Tracy-Walker
Tracy-Walker previously approved these changes Oct 23, 2025
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update each sleep to a CONSTANT for each, for easier adjustment. I disabled the test on GHA (MAc and Windows). Will need to file a follow up bug to investigate later.

Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Well done.

@krishpdev krishpdev merged commit 46a6c9e into mozilla:main Nov 4, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants