-
Notifications
You must be signed in to change notification settings - Fork 245
start agents.md to guide coding assistants #6134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7d7bc63 to
296e420
Compare
jwhitlock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @groovecoder. I feel like this is premature, and I'd prefer that you and other AI users collab outside the repo before committing. I am not an AI user, so I've done no testing of this file.
I suspect 500 lines is way too much, and will only work well with frontier models with large windows. I think 50 would be more appropriate.
More uninformed comments follow.
joeherm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me- I think it's worth having a discussion as a team before we merge it. I've played around with claude using the agents.md in the branch and think that it's giving good answers.
55e6d45 to
4debb9c
Compare
|
Okay I did a significant refactor here.
|
Vinnl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting it up, made it a bit more manageable for me. Gave some input on the frontend and testing piece.
4debb9c to
7b31620
Compare
joeherm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great- thanks for splitting it up.
jwhitlock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown paths seem sloppy, but maybe this is standard for LLM stuff, so I stopped after a while. Don't wait for my approval.
|
|
||
| The backend is organized into Django apps. | ||
|
|
||
| Check for an `.agents.md` file in an app directory for detailed guidance for that app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it is called agents.md, not .agents.md
.agents/agents.backend.md
Outdated
| - [privaterelay/.agents.md](privaterelay/.agents.md) - Core Django, settings, middleware, management commands | ||
| - [api/.agents.md](api/.agents.md) - REST API, authentication, serializers | ||
| - [emails/.agents.md](emails/.agents.md) - Email masking, AWS integration, metrics | ||
| - [phones/.agents.md](phones/.agents.md) - Phone masking, Twilio integration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files are agents.md (like privaterelay/agents.md), not .agents.md (like privaterelay/.agents.md). File is one folder up from here. So, should be something like:
[privaterelay/.agents.md](../privaterelay/agents.md)
.agents/agents.backend.md
Outdated
| - [.agents.md](.agents.md) - Project overview and global principles | ||
| - [.agents/agents.frontend.md](.agents/agents.frontend.md) - Frontend development | ||
| - [.agents/agents.testing.md](.agents/agents.testing.md) - Testing guidance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
paths are wrong here too
| - `docs/` - Comprehensive architecture documentation | ||
| - `README.md` - Full setup instructions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path appear wrong here too
.agents/agents.md
Outdated
|
|
||
| ### Single Frontend Static HTML Export | ||
|
|
||
| The frontend is built **once** and deployed to **all environments** (dev, stage, prod). Environment-specific values **cannot be baked into the build**. See "Environment-specific configuration" in [agents.backend.md](agents.backend.m) for more details. Next.js generates static HTML served by Django/Whitenoise. No server-side rendering. Dynamic routes must be handled carefully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
path is agents.backend.md, not agents.md
CLAUDE.md
Outdated
| @@ -0,0 +1,5 @@ | |||
| # Agent Lightbeam - Project Context | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: what is Agent Lightbeam?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, different project. nice catch.
EMMLynch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@groovecoder, thanks for the effort here and splitting out the agent files. Looks good.
7b31620 to
8c35d59
Compare
Nah the paths were sloppy because I tried to manually fix all the references after I split up and moved the files. When I told claude to do it, it did a much more thorough job cleaning them up. Updated. |
This PR fixes #.
How to test:
l10n changes have been submitted to the l10n repository, if any.I've added a unit test to test for potential regressions of this bug.All UI revisions follow the coding standards, and use Protocol / Nebula colors where applicable (see/frontend/src/styles/colors.scss).