This repository was archived by the owner on Apr 3, 2019. It is now read-only.
feat(fake-server): Have the fake server serve CORS requests, handle OAuth tokens. #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
shane-tomlinson
force-pushed
the
75-cors-oauth-fake-server
branch
from
7234968 to
5da64d8
Compare
Author
|
@mozilla/fxa-devs - r? |
rfk
approved these changes
Mar 19, 2019
Contributor
rfk
left a comment
rfk
left a comment
There was a problem hiding this comment.
Looks good to me! verifyOAuthToken will silently succeed if there's no Authorization header present, but you guard against that in the code here, so 👍.
…Auth tokens. fixes #75
shane-tomlinson
force-pushed
the
75-cors-oauth-fake-server
branch
from
5da64d8 to
046476c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #75
We want to retire fxa-basket-proxy and still need a way to test that basket functionality works.
Right now the basket proxy shuttles requests to the basket server, using a shared secret for authentication. Basket itself can also authenticate with OAuth tokens.
So that we can continue to test on fxa-dev boxes, fake.js serves CORS requests and accepts OAuth access tokens.
blocks mozilla/fxa-content-server#7050