Skip to content
This repository was archived by the owner on Apr 3, 2019. It is now read-only.

Conversation

@shreya99oak
Copy link
Contributor

fixes #6268
Sorry for the delay! Pls. review @shane-tomlinson

@shreya99oak shreya99oak changed the title fix(style): spinner and modal size fix(modal): spinner and modal size Mar 20, 2019
@farhan787
Copy link
Contributor

@shreya99oak IMHO you should read https://github.com/mozilla/fxa-content-server/blob/master/CONTRIBUTING.md#git-commit-guidelines because the commit message should contain style(modal)...

@shreya99oak shreya99oak changed the title fix(modal): spinner and modal size style(modal): spinner and modal size Mar 20, 2019
Copy link

@shane-tomlinson shane-tomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shreya99oak for this. I want to get @ryanfeeley's feedback on which spinner he means. The update seems unexpectedly large to me:

giant-spinner

The other thing is that we should use the same spinner when opening the Camera link.

@shreya99oak
Copy link
Contributor Author

Thanks @shreya99oak for this. I want to get @ryanfeeley's feedback on which spinner he means. The update seems unexpectedly large to me:

giant-spinner

The other thing is that we should use the same spinner when opening the Camera link.

Ok cool, yes even I had felt odd about the spinner size, but I assumed this is what he meant

@shane-tomlinson
Copy link

This repo has been deprecated and migrated to https://github.com/mozill/fxa. Please open this PR against that repo.

@ryanfeeley ryanfeeley removed their assignment Apr 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants